Increase notification timeout to 120s |
||||||
Issue descriptionChrome Version: All OS: CrOS What steps will reproduce the problem? (1) Start print job of complicated page (i.e. yahoo.co.jp) (2) Wait What is the expected result? Pages are printed eventually What happens instead? Print job is cancelled when we think it times out (after 20s). We can't differentiate between an unreachable printer and a job that is expensive to render. In the meantime, allow 120s to render a job.
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8229631e3aca5b48c77211ce443c5947c7c42f4f commit 8229631e3aca5b48c77211ce443c5947c7c42f4f Author: Sean Kau <skau@chromium.org> Date: Mon Dec 04 20:14:45 2017 Increase print job timeout to 120s from 20s. Some print jobs take a very long time to render. Add some buffer to allow rendering to complete. Long term, we hope to reduce the timeout to 20s to detect if a printer is reachable. If a printer is unreachable, this change will result in extending the time a user waits from 20 to 120s. This should only be encountered by users setting up their printer for the first time. Bug: 786182 , 791230 Change-Id: I5088654b3f8a68b1178efeef98c5cb66dfe4647c Reviewed-on: https://chromium-review.googlesource.com/804606 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#521425} [modify] https://crrev.com/8229631e3aca5b48c77211ce443c5947c7c42f4f/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Dec 4 2017
,
Dec 4 2017
,
Dec 4 2017
,
Dec 5 2017
Approving merge to M64 Chrome OS.
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15b251800452c14148a1cc06312313a1baaf4665 commit 15b251800452c14148a1cc06312313a1baaf4665 Author: Sean Kau <skau@chromium.org> Date: Tue Dec 05 22:11:00 2017 Increase print job timeout to 120s from 20s. Some print jobs take a very long time to render. Add some buffer to allow rendering to complete. Long term, we hope to reduce the timeout to 20s to detect if a printer is reachable. If a printer is unreachable, this change will result in extending the time a user waits from 20 to 120s. This should only be encountered by users setting up their printer for the first time. Bug: 786182 , 791230 Change-Id: I5088654b3f8a68b1178efeef98c5cb66dfe4647c Reviewed-on: https://chromium-review.googlesource.com/804606 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521425}(cherry picked from commit 8229631e3aca5b48c77211ce443c5947c7c42f4f) Reviewed-on: https://chromium-review.googlesource.com/809766 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#39} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/15b251800452c14148a1cc06312313a1baaf4665/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by skau@chromium.org
, Dec 2 2017Labels: M-64