New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791214 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Add major type 7 support to CBOR

Project Member Reported by kpaulhamus@chromium.org, Dec 2 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07540c6d850ed6e0fa508d63c20a8ce96d751de6

commit 07540c6d850ed6e0fa508d63c20a8ce96d751de6
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Dec 21 02:51:43 2017

Support CBOR encoding and decoding of simple value

Added support for simple data type(major type 7) for CBORValue,
CBORWriter, and CBORReader. Major type 7 corresponds to two possible
data types in CBOR: floating point numbers and simple values. This CL
only adds support for simple data types.

Bug:  791214 
Change-Id: I0cd10d6749753f457490c385d8aeff62b82e81f5
Reviewed-on: https://chromium-review.googlesource.com/811906
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525572}
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_reader.cc
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_reader.h
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_reader_unittest.cc
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_values.cc
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_values.h
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_values_unittest.cc
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_writer.cc
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_writer.h
[modify] https://crrev.com/07540c6d850ed6e0fa508d63c20a8ce96d751de6/content/browser/webauth/cbor/cbor_writer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment