New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791205 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Jan 2018
Cc:
ssid@chromium.org
shaktisahu@chromium.org
dtrainor@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Memory tracing for download service

Project Member Reported by xingliu@chromium.org, Dec 2 2017 
Recently prefetch team found "Memory.Browser.PrivateMemoryFootprint" histogram increased in finch experiments.

We can add memory tracking and trace events in download service for more detailed memory analysis.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bc6dc32cd3c055ab1380a08978c3571707c222a

commit 4bc6dc32cd3c055ab1380a08978c3571707c222a
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Dec 08 22:15:47 2017

Download service: trace event and memory tracking.

This CL adds a trace event namespace and memory estimation, used in
memory infra in chrome://tracing.

Bug:  791205 
Change-Id: Icef6de4a2504a24fa44042e4e57364b23f6ffefc
Reviewed-on: https://chromium-review.googlesource.com/804638
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522898}
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/content/internal/download_driver_impl.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/content/public/all_download_item_notifier.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/content/public/all_download_item_notifier.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/BUILD.gn
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/controller_impl.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/controller_impl.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/download_driver.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/entry.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/entry.h
[add] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/memory_tracker.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/model.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/model_impl.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/model_impl.h
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/test/test_download_driver.cc
[modify] https://crrev.com/4bc6dc32cd3c055ab1380a08978c3571707c222a/components/download/internal/test/test_download_driver.h

Comment 2 by ssid@chromium.org, Jan 30 2018

Cc: ssid@chromium.org

Comment 3 by ssid@chromium.org, Jan 30 2018

Components: Internals>Instrumentation>Memory

Comment 4 by xingliu@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f27427cebef95bf0558b99cdd1d7d721916b52a

commit 2f27427cebef95bf0558b99cdd1d7d721916b52a
Author: Siddhartha <ssid@chromium.org>
Date: Thu Feb 01 06:20:59 2018

Fix download controller memory dump provider

GetOrCreate dump is only used when the provider is not certain if the
dump should be created. Multiple dumps should have unique IDs.

BUG= 791205 

Change-Id: I46dec025517fb22f0b62a12d7e3ae64c45aa333a
Reviewed-on: https://chromium-review.googlesource.com/892488
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533591}
[modify] https://crrev.com/2f27427cebef95bf0558b99cdd1d7d721916b52a/components/download/internal/background_service/controller_impl.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4940d20bc6adc44200127d70636f920e3c680a23

commit 4940d20bc6adc44200127d70636f920e3c680a23
Author: Siddhartha <ssid@chromium.org>
Date: Fri Feb 16 05:38:26 2018

Memory-infra: Whitelist download service provider

BUG= 791205 

Change-Id: I13e256c1876d6c0ce7e3dc3044bce716666d01e5
Reviewed-on: https://chromium-review.googlesource.com/922889
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537219}
[modify] https://crrev.com/4940d20bc6adc44200127d70636f920e3c680a23/base/trace_event/memory_infra_background_whitelist.cc
►

Sign in to add a comment