chrome-release-bot@ to set "NOAUTOREVERT=true" in commit message |
||
Issue descriptionBackground: https://crbug.com/791050#c6 After talking to dpranke@, we think that it is better for sheriffs to handle triggering CLs like the Chrome version bump CL as normal cases: findings by Findit should still show up on sheriff-o-matic, and then sheriffs handle them based on their own judgement. If a CL like the Chrome version bump should never be reverted, the commit message of the CL itself should state "no revert", why, and what's the next step (how to deal with compile/test failures it triggers). To skip Findit's auto-revert flow (auto-create and auto-commit), here is an example https://chromium-review.googlesource.com/c/chromium/src/+/744731
,
Dec 2 2017
Currently chrome-release-bot@'s CLs are all backlisted, and won't show up on Sherif-o-Matic and won't be reverted by Findit.
,
Jan 25 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/e147b0ee536e1fc0f5d4edc763ed114ed4c8895b commit e147b0ee536e1fc0f5d4edc763ed114ed4c8895b Author: Michael Moss <mmoss@google.com> Date: Thu Jan 25 17:46:21 2018
,
Jan 25 2018
VERSION bumps will now include the message: # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true |
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Dec 2 2017