Resolution slider should not be disabled in tablet mode |
|||||||||||
Issue descriptionToT What steps will reproduce the problem? (1) Switch to tablet mode (2) Open display settings What is the expected result? The resolution slider is still enabled. What happens instead? The resolution slider is disabled. This is regression bug.
,
Dec 2 2017
can you check if 63 has this too?
,
Dec 2 2017
I think yes, because https://chromium-review.googlesource.com/c/chromium/src/+/619295 was landed before M63 branch (Oct. 12)
,
Dec 2 2017
,
Dec 3 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b11ecd627ca7b493fe40f3a28f01959805381f5 commit 2b11ecd627ca7b493fe40f3a28f01959805381f5 Author: Weidong Guo <weidongg@chromium.org> Date: Mon Dec 04 18:59:42 2017 Enable resolution slider in tablet mode Bug: 791199 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I22cfd969f415d32a5bd2aa135e610a55ddab857c Reviewed-on: https://chromium-review.googlesource.com/804939 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521400} [modify] https://crrev.com/2b11ecd627ca7b493fe40f3a28f01959805381f5/chrome/browser/resources/settings/device_page/display.html
,
Dec 4 2017
,
Dec 4 2017
This bug requires manual review: We are only 0 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2017
,
Dec 4 2017
Approving merge to M64 Chrome OS.
,
Dec 5 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a82c5cd45eef2be1b7b28b606264065834930995 commit a82c5cd45eef2be1b7b28b606264065834930995 Author: Weidong Guo <weidongg@chromium.org> Date: Tue Dec 05 21:19:12 2017 Enable resolution slider in tablet mode TBR=stevenjb@chromium.org Bug: 791199 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I22cfd969f415d32a5bd2aa135e610a55ddab857c Reviewed-on: https://chromium-review.googlesource.com/804939 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521400}(cherry picked from commit 2b11ecd627ca7b493fe40f3a28f01959805381f5) Reviewed-on: https://chromium-review.googlesource.com/809764 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#38} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a82c5cd45eef2be1b7b28b606264065834930995/chrome/browser/resources/settings/device_page/display.html
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09791ac48f2fef682e0f395099740eda589547a commit a09791ac48f2fef682e0f395099740eda589547a Author: Weidong Guo <weidongg@chromium.org> Date: Tue Dec 05 21:22:05 2017 Enable resolution slider in tablet mode TBR=stevenjb@chromium.org Bug: 791199 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I22cfd969f415d32a5bd2aa135e610a55ddab857c Reviewed-on: https://chromium-review.googlesource.com/804939 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521400}(cherry picked from commit 2b11ecd627ca7b493fe40f3a28f01959805381f5) Reviewed-on: https://chromium-review.googlesource.com/809765 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#644} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/a09791ac48f2fef682e0f395099740eda589547a/chrome/browser/resources/settings/device_page/display.html |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by weidongg@chromium.org
, Dec 2 2017