New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791196 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

half pixel sizing error when text overflows container

Reported by gameho...@gmail.com, Dec 2 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Example URL:
https://jsfiddle.net/d78ugn7z/1/

Steps to reproduce the problem:
1. multiple fieldset/divs with multiple button elements
2. buttons fixed size, in one group text will overflow (however slightly)
3. resulting fieldset  height off by 0.5 pixels, affecting flow of floating fieldsets.

What is the expected behavior?
fieldsets/divs should have the exact same height as the elements they contain are all the same height. This is behavior on all other browsers tested (firefox, IE)

What went wrong?
layout of floating fieldsets or divs visually wrong, leaving large gaps. This happens with or without the legend or border. various styles applied to attempt consistency but only workaround is to hardcode the height of the fieldset, which breaks if one set has more than one line worth of buttons.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes not sure, within last 30 days.

Does this work in other browsers? Yes

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 10.0
Flash Version: 

simplest repro case in jsfiddle. No javascript involved.
 

Comment 1 Deleted

Simpler case, this seems to be an issue aligning divs, not overflowing text. 

When buttons have different number of lines of text, they cannot be vertically aligned. Tried all possible values of vertical-align on the container.

https://jsfiddle.net/d78ugn7z/3/
vertical-align on the container was the wrong thing to try. This does seem to be limited to "vertical-align: middle" on the buttons.

The problem is, using "vertical-align: middle" on a series of button elements of the exact same height, they alignment will be unpredictable, at least within about 1/2 pixel. This can lead to parent elements of different heights and break the flow of floating elements.

https://jsfiddle.net/d78ugn7z/9/

Components: -Blink Blink>Layout
Labels: -Type-Bug hasbisect-per-revision M-64 Needs-Triage-M62 Type-Bug-Regression
Owner: ka...@opera.com
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Win-7 using chrome reported version #62.0.3202.94, #64.0.3282.5 
Bisect Information:
=====================
Good build: 62.0.3169.0    Revision(490187)
Bad Build : 62.0.3170.0    Revision(490562)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/97eedd95bbffdf6b2a24494a599a5089bcad1f94..abc4634436dd4fc1b909ec04e589288464d432aa

From the above change log suspecting below change
Review-Url: https://chromium-review.googlesource.com/543141

Karl Anders Øygard@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 6 by ka...@opera.com, Feb 28 2018

Owner: karloygard@chromium.org

Sign in to add a comment