New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791187 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 791608
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

webgl_conformance_gl_passthrough_tests failing (crash) on Linux Release (Intel HD 630)

Project Member Reported by piman@chromium.org, Dec 1 2017

Issue description

https://ci.chromium.org/buildbot/chromium.gpu.fyi/Linux%20Release%20%28Intel%20HD%20630%29/1410

Failing test:
 gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_extensions_oes_texture_half_float_with_canvas


  	Thread 0 (crashed)
  	 0  libc-2.24.so + 0x374a2
  	    rax = 0x0000000000000006   rdx = 0x0000000000000000
  	    rcx = 0x00007f1aa728477f   rbx = 0x000000000000001f
  	    rsi = 0x00007fff0afa72a0   rdi = 0x0000000000000002
  	    rbp = 0x00007fff0afa74e0   rsp = 0x00007fff0afa73b0
  	     r8 = 0x0000000000000000    r9 = 0x00007fff0afa72a0
  	    r10 = 0x0000000000000008   r11 = 0x0000000000000246
  	    r12 = 0x00007fff0afa79b8   r13 = 0x00007fff0afa79a8
  	    r14 = 0x00007fff0afa79b0   r15 = 0x0000365a77dbfc68
  	    rip = 0x00007f1aa72864a2
  	    Found by: given as instruction pointer in context
  	 1  chrome!~LogMessage [callback.h : 94 + 0x7]
  	    rbp = 0x00007fff0afa7980   rsp = 0x00007fff0afa74f0
  	    rip = 0x0000555f7f414fc3
  	    Found by: previous frame's frame pointer
  	 2  chrome!DeleteQueriesEXT [gles2_implementation_impl_autogen.h : 2951 + 0x8]
  	    rbx = 0x00007fff0afa79a8   rbp = 0x00007fff0afa7b00
  	    rsp = 0x00007fff0afa7990   r12 = 0x0000555f7ae144e2
  	    r13 = 0x0000365a76ba4600   r14 = 0x0000185a26c1c350
  	    r15 = 0x0000000000000001   rip = 0x0000555f808367eb
  	    Found by: call frame info
  	 3  chrome!Reset [SharedContextRateLimiter.cpp : 75 + 0xb]
  	    rbx = 0x00001af2f805e9b0   rbp = 0x00007fff0afa7c70
  	    rsp = 0x00007fff0afa7b10   r12 = 0x00001af2f805e9cc
  	    r13 = 0x0000555f80836550   r14 = 0x0000365a76ba4600
  	    r15 = 0x00000795183ba798   rip = 0x0000555f82b0a997
  	    Found by: call frame info
  	 4  chrome!SkipQueuedDrawCommands [Canvas2DLayerBridge.cpp : 528 + 0x5]
  	    rbx = 0x00001af2f816da10   rbp = 0x00007fff0afa7ca0
  	    rsp = 0x00007fff0afa7c80   r12 = 0x00000795183b8728
  	    r13 = 0x0000365a77009210   r14 = 0x00007fff0afa7f90
  	    r15 = 0x00000795183ba798   rip = 0x0000555f82b054f4
  	    Found by: call frame info
  	 5  chrome!CheckOverdraw [ImageBuffer.h : 110 + 0x6]
  	    rbx = 0x00000000000000ff   rbp = 0x00007fff0afa7e50
  	    rsp = 0x00007fff0afa7cb0   r12 = 0x00000795183b8728
  	    r13 = 0x0000365a77009210   r14 = 0x00007fff0afa7f90
  	    r15 = 0x00000795183ba798   rip = 0x0000555f838facb1
  	    Found by: call frame info
  	 6  chrome!fillRect [BaseRenderingContext2D.h : 446 + 0x10]
  	    rbx = 0x00000795183b8728   rbp = 0x00007fff0afa8110
  	    rsp = 0x00007fff0afa7e60   r12 = 0x00007fff0afa8240
  	    r13 = 0x0000555f84803660   r14 = 0x00000795183ba798
  	    r15 = 0x00007fff0afa7fb8   rip = 0x0000555f838f877c
  	    Found by: call frame info
  	 7  chrome!fillRectMethodCallback [V8CanvasRenderingContext2D.cpp : 1020 + 0x14]
  	    rbx = 0x00007fff0afa8518   rbp = 0x00007fff0afa81a0
  	    rsp = 0x00007fff0afa8120   r12 = 0x00007fff0afa8240
  	    r13 = 0x0000555f84803660   r14 = 0x00000795183b8728
  	    r15 = 0x0000365a76a1c000   rip = 0x0000555f83919635
  	    Found by: call frame info


This is an assert (I believe https://cs.chromium.org/chromium/src/gpu/command_buffer/client/gles2_implementation_impl_autogen.h?type=cs&q=GLES2Implementation::DeleteQueriesEXT&sq=package:chromium&l=2953 ), which indicate that we're trying to delete query id 0.

This is very likely exposed by xlai's https://chromium.googlesource.com/chromium/src/+/74f45cf7fd9cdd165d04d6079cb54a56a1a47075 / https://chromium-review.googlesource.com/c/chromium/src/+/800750 because it touches precisely a function in that stack trace.
I think this is a bug in SharedContextRateLimiter though, which looks like it pushes query 0 on its queue if can_use_sync_queries_ is not set, and DeleteQuery unconditionally.
 

Comment 1 by piman@chromium.org, Dec 1 2017

Components: Internals>GPU>Canvas2D
Labels: Hotlist-PixelWrangler

Comment 2 by xlai@chromium.org, Dec 6 2017

Cc: -junov@chromium.org
Owner: junov@chromium.org
Status: Fixed (was: Untriaged)
This bug is already fixed by junov in https://chromium-review.googlesource.com/c/chromium/src/+/806678.

Comment 3 by junov@chromium.org, Dec 6 2017

Mergedinto: 791608
Status: Duplicate (was: Fixed)
Let's mark it as a Dupe then.

Sign in to add a comment