New issue
Advanced search Search tips

Issue 791183 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

use netdev instead of vlan for cros qemu 2.11.1

Project Member Reported by achuith@chromium.org, Dec 1 2017

Issue description

I believe vlan is being deprecated:
https://www.linux-kvm.org/page/Networking

With qemu 2.11.1, I get the following warning:
15:25:50: INFO: RunCommand: /usr/local/google/home/achuith/code/qemu/build/qemu-2.11.0-rc3/build/x86_64-softmmu/qemu-system-x86_64 -m 2G -smp 4 -vga virtio -daemonize -pidfile /tmp/cros_vm/kvm.pid -chardev 'pipe,id=control_pipe,path=/tmp/cros_vm/kvm.monitor' -serial file:/tmp/cros_vm/kvm.monitor.serial -mon 'chardev=control_pipe' -net 'nic,model=virtio,vlan=9222' -net 'user,hostfwd=tcp:127.0.0.1:9222-:22,vlan=9222' -drive 'file=/usr/local/google/home/achuith/code/chrome/.cros_cache/chrome-sdk/tarballs/amd64-generic+10171.0.0+chromiumos_qemu_image.tar.xz/chromiumos_qemu_image.bin,index=0,media=disk,cache=unsafe,format=raw' -enable-kvm
qemu-system-x86_64: -net nic,model=virtio,vlan=9222: 'vlan' is deprecated. Please use 'netdev' instead.

 
Cc: pprabhu@chromium.org
Owner: ----
Good idea... uh... but not on my plate atm :)
Components: OS>Systems
A fix should update both chromite/scripts/cros_vm.py, and src/scripts/lib/cros_vm_lib.sh
Components: -OS>Systems Infra>Client>ChromeOS>Build
Status: Fixed (was: Untriaged)
cros_vm.py was fixed in https://chromium-review.googlesource.com/1020307

cros_vm_lib.sh is dead code

Sign in to add a comment