New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791182 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Not calling cancel when webview starts

Project Member Reported by michaelbai@chromium.org, Dec 1 2017

Issue description

not calling cancel when webview starts, in theory, this change shouldn't cause other issues, because cancel is still called when user touch the field, but this change is still considered as a 'BIG' change, needs to be verified by QA, target it in M64. 

see http://b/69461853
 
Components: Mobile>WebView
Labels: M-64 OS-Android
Owner: michaelbai@chromium.org
Status: Assigned (was: Untriaged)
Labels: -M-64 M-65
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6475c17c2d76cb962ea8cb3641ea365cd2a277df

commit 6475c17c2d76cb962ea8cb3641ea365cd2a277df
Author: Tao Bai <michaelbai@chromium.org>
Date: Thu Dec 07 01:55:11 2017

[WebView autofill] Not call cancel when WebView starts

Calling cancel() seems not neccessary when WebView first starts.
this could break the exsiting autofill session when WebView is
only for ads.

Bug:  791182 
Change-Id: I7feb37f930ba1eedcab6cbeb50645d4128656fe8
Reviewed-on: https://chromium-review.googlesource.com/806319
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522302}
[modify] https://crrev.com/6475c17c2d76cb962ea8cb3641ea365cd2a277df/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/6475c17c2d76cb962ea8cb3641ea365cd2a277df/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java

Status: Fixed (was: Assigned)
michaelbai@, can you please let me know how to verify this issue manually? and i do see bug http://b/69461853 ( Still in Assigned state )

Cc: felipeal@google.com changwan@chromium.org
Status: Assigned (was: Fixed)
I will only call cancel when autofill session is started.

Comment 8 by felipeal@google.com, Jan 16 2018

I think this is only fixed on M65; I tried it with Chrome Beta (64.0.3282.85) and my service (https://github.com/the-felipeal/android-AutofillFramework) and it still failed.

Then I switched to Canary (65.0.3322.0), and it worked.
Yes, it targets on M65.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dab4bfae1c73f938124418c30efd28f32c9f1e8

commit 8dab4bfae1c73f938124418c30efd28f32c9f1e8
Author: Tao Bai <michaelbai@chromium.org>
Date: Fri Jan 19 23:44:56 2018

Keep autofill session alive.

Cancel the previous autofill session until the new autofill session
is triggered. We don't cancel the autofill session when WebView
navigates to the new page now.

This should also improve the detection of form submission.

Bug:  791182 
Change-Id: I883b322f921ef29221995681ad07044d35bfb76d
Reviewed-on: https://chromium-review.googlesource.com/876507
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530660}
[modify] https://crrev.com/8dab4bfae1c73f938124418c30efd28f32c9f1e8/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/8dab4bfae1c73f938124418c30efd28f32c9f1e8/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java

Labels: Merge-Request-65
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 23 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 25 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac6483b070067994a64b42bf9402e9293e246439

commit ac6483b070067994a64b42bf9402e9293e246439
Author: Tao Bai <michaelbai@chromium.org>
Date: Thu Jan 25 22:45:23 2018

Keep autofill session alive.

Cancel the previous autofill session until the new autofill session
is triggered. We don't cancel the autofill session when WebView
navigates to the new page now.

This should also improve the detection of form submission.

Bug:  791182 
Change-Id: I883b322f921ef29221995681ad07044d35bfb76d
Reviewed-on: https://chromium-review.googlesource.com/876507
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530660}(cherry picked from commit 8dab4bfae1c73f938124418c30efd28f32c9f1e8)
Reviewed-on: https://chromium-review.googlesource.com/886827
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#102}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/ac6483b070067994a64b42bf9402e9293e246439/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/ac6483b070067994a64b42bf9402e9293e246439/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java

there could be side effect that some Autofill features won't work correctly, for the fix itself, QA have no way to verify it.
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
marking verified as per comment#14

Sign in to add a comment