Not calling cancel when webview starts |
|||||||||
Issue descriptionnot calling cancel when webview starts, in theory, this change shouldn't cause other issues, because cancel is still called when user touch the field, but this change is still considered as a 'BIG' change, needs to be verified by QA, target it in M64. see http://b/69461853
,
Dec 2 2017
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6475c17c2d76cb962ea8cb3641ea365cd2a277df commit 6475c17c2d76cb962ea8cb3641ea365cd2a277df Author: Tao Bai <michaelbai@chromium.org> Date: Thu Dec 07 01:55:11 2017 [WebView autofill] Not call cancel when WebView starts Calling cancel() seems not neccessary when WebView first starts. this could break the exsiting autofill session when WebView is only for ads. Bug: 791182 Change-Id: I7feb37f930ba1eedcab6cbeb50645d4128656fe8 Reviewed-on: https://chromium-review.googlesource.com/806319 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#522302} [modify] https://crrev.com/6475c17c2d76cb962ea8cb3641ea365cd2a277df/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java [modify] https://crrev.com/6475c17c2d76cb962ea8cb3641ea365cd2a277df/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
,
Dec 7 2017
,
Jan 2 2018
michaelbai@, can you please let me know how to verify this issue manually? and i do see bug http://b/69461853 ( Still in Assigned state )
,
Jan 6 2018
,
Jan 16 2018
I will only call cancel when autofill session is started.
,
Jan 16 2018
I think this is only fixed on M65; I tried it with Chrome Beta (64.0.3282.85) and my service (https://github.com/the-felipeal/android-AutofillFramework) and it still failed. Then I switched to Canary (65.0.3322.0), and it worked.
,
Jan 16 2018
Yes, it targets on M65.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dab4bfae1c73f938124418c30efd28f32c9f1e8 commit 8dab4bfae1c73f938124418c30efd28f32c9f1e8 Author: Tao Bai <michaelbai@chromium.org> Date: Fri Jan 19 23:44:56 2018 Keep autofill session alive. Cancel the previous autofill session until the new autofill session is triggered. We don't cancel the autofill session when WebView navigates to the new page now. This should also improve the detection of form submission. Bug: 791182 Change-Id: I883b322f921ef29221995681ad07044d35bfb76d Reviewed-on: https://chromium-review.googlesource.com/876507 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#530660} [modify] https://crrev.com/8dab4bfae1c73f938124418c30efd28f32c9f1e8/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java [modify] https://crrev.com/8dab4bfae1c73f938124418c30efd28f32c9f1e8/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
,
Jan 22 2018
,
Jan 23 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac6483b070067994a64b42bf9402e9293e246439 commit ac6483b070067994a64b42bf9402e9293e246439 Author: Tao Bai <michaelbai@chromium.org> Date: Thu Jan 25 22:45:23 2018 Keep autofill session alive. Cancel the previous autofill session until the new autofill session is triggered. We don't cancel the autofill session when WebView navigates to the new page now. This should also improve the detection of form submission. Bug: 791182 Change-Id: I883b322f921ef29221995681ad07044d35bfb76d Reviewed-on: https://chromium-review.googlesource.com/876507 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530660}(cherry picked from commit 8dab4bfae1c73f938124418c30efd28f32c9f1e8) Reviewed-on: https://chromium-review.googlesource.com/886827 Reviewed-by: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#102} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/ac6483b070067994a64b42bf9402e9293e246439/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java [modify] https://crrev.com/ac6483b070067994a64b42bf9402e9293e246439/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
,
Jan 30 2018
there could be side effect that some Autofill features won't work correctly, for the fix itself, QA have no way to verify it.
,
Feb 6 2018
,
Feb 7 2018
marking verified as per comment#14 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by michaelbai@chromium.org
, Dec 1 2017Labels: M-64 OS-Android
Owner: michaelbai@chromium.org
Status: Assigned (was: Untriaged)