New issue
Advanced search Search tips

Issue 791176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl issue -r fails with AssertionError

Project Member Reported by thestig@chromium.org, Dec 1 2017

Issue description

I tried to add "git cl checkout --print" in https://chromium-review.googlesource.com/804614 but agable@ said to use "git cl issue -r" instead. Then I tried it in my Chromium checkout, which has many branches, new and old. It doesn't work though:

$ git cl issue -r 804205
Traceback (most recent call last):
  File "/home/thestig/depot_tools/git_cl.py", line 6193, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/thestig/depot_tools/git_cl.py", line 6175, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/thestig/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/thestig/depot_tools/git_cl.py", line 4540, in CMDissue
    cl = Changelist(branchref=branch)
  File "/home/thestig/depot_tools/git_cl.py", line 1146, in __init__
    assert branchref.startswith('refs/heads/')
AssertionError

The first branch I have is named "autofill_b446322" and that's what |branchref| is. It's a branch that's at 6334aa835e879d9e025679d276f48149ba97b665 - I never actually got around to writing any code for bug 446322 and just left the branch sitting there.
 
Cc: -aga...@chromium.org
Owner: aga...@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/#/c/chromium/tools/depot_tools/+/806239
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/ad64abd69aedabe7da5db9ca6de6fd28fca879d2

commit ad64abd69aedabe7da5db9ca6de6fd28fca879d2
Author: Aaron Gable <agable@chromium.org>
Date: Mon Dec 04 18:02:25 2017

git-cl: Fix 'git cl issue --reverse'

While ripping SVN support out of git-cl, the Changelist() constructor
changed to require that the branch name start with "refs/heads/",
but the CMDissue --reverse code was never updated to feed it the
fully-qualified refname.

R=thestig

Bug:  791176 
Change-Id: Ia7fee0f77fec080d91f34ad43bfd9f7c6a4bf64b
Reviewed-on: https://chromium-review.googlesource.com/806239
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/ad64abd69aedabe7da5db9ca6de6fd28fca879d2/git_cl.py

Status: Fixed (was: Started)

Sign in to add a comment