Add force-sign-in metrics |
||||||
Issue descriptionAdding metrics related to force-sign-in policy.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afccf64114b233fe65af7526b2f015efb2d1e7c1 commit afccf64114b233fe65af7526b2f015efb2d1e7c1 Author: Owen Min <zmin@chromium.org> Date: Thu Dec 07 22:23:39 2017 Add metrics to track the UI event when a user clicks a locked profile on UserManager. Bug: 791171 Change-Id: I11e8c1cb1f2be8cf58d9cb53a45d1f7ce4092421 Reviewed-on: https://chromium-review.googlesource.com/809617 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522576} [modify] https://crrev.com/afccf64114b233fe65af7526b2f015efb2d1e7c1/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/afccf64114b233fe65af7526b2f015efb2d1e7c1/chrome/browser/ui/webui/signin/user_manager_screen_handler.h [modify] https://crrev.com/afccf64114b233fe65af7526b2f015efb2d1e7c1/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc [modify] https://crrev.com/afccf64114b233fe65af7526b2f015efb2d1e7c1/tools/metrics/histograms/enums.xml [modify] https://crrev.com/afccf64114b233fe65af7526b2f015efb2d1e7c1/tools/metrics/histograms/histograms.xml
,
Dec 11 2017
Force-signin is planed to be launched on 64. The two CLs above collect metrics data related to some UI behavior so that we could improve UX based on the data in the future. All metrics have been confirmed on the metrics website and has been covered by unittest/browsertest.
,
Dec 11 2017
Can you please mark which OS's this impacts?
,
Dec 11 2017
It's on Windows.
,
Dec 12 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8249ecab2ba51a48f7c70d7bede6c2137390d435 commit 8249ecab2ba51a48f7c70d7bede6c2137390d435 Author: Owen Min <zmin@chromium.org> Date: Wed Dec 13 16:32:58 2017 Merge "Add metrics to track the status of force signin verfication." Metrics to count whether the verification request will be sent when profile is loaded. Metrics to count the amount of time from profile loaded to verification finished. TBR=zmin@chromium.org (cherry picked from commit 4837f6144ff032ecdb88d866b2aece93db3e6a64) Bug: 791171 Change-Id: I693eb5bd2289fc7ba7c295dbd45309d1b04ffe26 Reviewed-on: https://chromium-review.googlesource.com/804754 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521830} Reviewed-on: https://chromium-review.googlesource.com/824742 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#200} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/8249ecab2ba51a48f7c70d7bede6c2137390d435/chrome/browser/signin/force_signin_verifier.cc [modify] https://crrev.com/8249ecab2ba51a48f7c70d7bede6c2137390d435/chrome/browser/signin/force_signin_verifier.h [modify] https://crrev.com/8249ecab2ba51a48f7c70d7bede6c2137390d435/chrome/browser/signin/force_signin_verifier_unittest.cc [modify] https://crrev.com/8249ecab2ba51a48f7c70d7bede6c2137390d435/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fea474e19d6a4e470939813a4b1bdfce6104a0d commit 5fea474e19d6a4e470939813a4b1bdfce6104a0d Author: Owen Min <zmin@chromium.org> Date: Wed Dec 13 16:37:19 2017 Merge "Add metrics to track the UI event when a user clicks a locked profile on UserManager." TBR=zmin@chromium.org (cherry picked from commit afccf64114b233fe65af7526b2f015efb2d1e7c1) Bug: 791171 Change-Id: I11e8c1cb1f2be8cf58d9cb53a45d1f7ce4092421 Reviewed-on: https://chromium-review.googlesource.com/809617 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522576} Reviewed-on: https://chromium-review.googlesource.com/824723 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#202} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/5fea474e19d6a4e470939813a4b1bdfce6104a0d/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/5fea474e19d6a4e470939813a4b1bdfce6104a0d/chrome/browser/ui/webui/signin/user_manager_screen_handler.h [modify] https://crrev.com/5fea474e19d6a4e470939813a4b1bdfce6104a0d/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc [modify] https://crrev.com/5fea474e19d6a4e470939813a4b1bdfce6104a0d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5fea474e19d6a4e470939813a4b1bdfce6104a0d/tools/metrics/histograms/histograms.xml
,
Jan 11
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5 2017