mosys: platform id command causes stumpy (and a few others) to reset |
||||
Issue descriptionThe `mosys platform id` command works by calling all the other `mosys platform` subcommands. One of those commands is "reset", which is only defined for a handful of boards: butterfly, kiev, parrot, stout, stumpy
,
Dec 4 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/de4c1a14ab5198153564745e7c3244f5d05c3a7d commit de4c1a14ab5198153564745e7c3244f5d05c3a7d Author: Lann Martin <lannm@chromium.org> Date: Tue Dec 05 04:02:59 2017 Don't run `platform reset` with `platform id` Filter platform subcommands to those with ARG_TYPE_GETTER, which should avoid subcommands that mutate the system like "reset". BRANCH=none BUG= chromium:791164 TEST=deploy to stumpy; mosys platform id Change-Id: I3104b4a25cc974689bafc528d2fede820f238de8 Reviewed-on: https://chromium-review.googlesource.com/804795 Commit-Ready: Lann Martin <lannm@chromium.org> Tested-by: Lann Martin <lannm@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/de4c1a14ab5198153564745e7c3244f5d05c3a7d/core/command/platform.c
,
Dec 7 2017
Nice work, Lann.
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/6afcf60b480f0c2f6dcfe67b867303f059e9ad88 commit 6afcf60b480f0c2f6dcfe67b867303f059e9ad88 Author: Lann Martin <lannm@chromium.org> Date: Tue Mar 27 01:14:51 2018 Don't run `platform reset` with `platform id` Filter platform subcommands to those with ARG_TYPE_GETTER, which should avoid subcommands that mutate the system like "reset". BRANCH=none BUG= chromium:791164 TEST=deploy to stumpy; mosys platform id Change-Id: I3104b4a25cc974689bafc528d2fede820f238de8 Reviewed-on: https://chromium-review.googlesource.com/804795 Commit-Ready: Lann Martin <lannm@chromium.org> Tested-by: Lann Martin <lannm@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit de4c1a14ab5198153564745e7c3244f5d05c3a7d) Reviewed-on: https://chromium-review.googlesource.com/981205 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/6afcf60b480f0c2f6dcfe67b867303f059e9ad88/core/command/platform.c |
||||
►
Sign in to add a comment |
||||
Comment 1 by la...@chromium.org
, Dec 1 2017