The background and foreground color of exit warning screen regressed. |
|||||||
Issue descriptionIt looks like we forgot to set the colors through binding.
,
Dec 2 2017
,
Dec 3 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cf56261d2837ed350243f4ae6d0632d9b9bdce9 commit 9cf56261d2837ed350243f4ae6d0632d9b9bdce9 Author: Biao She <bshe@chromium.org> Date: Mon Dec 04 14:55:07 2017 Fix exit warning screen color regression TBR=bshe@chromium.org (cherry picked from commit 9165179ec998c264c5715c1c59f45c5155c23ddd) Bug: 791159 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbc8b244d2f39c61eeaccf177cf306e4edc1ba4c Reviewed-on: https://chromium-review.googlesource.com/804339 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521166} Reviewed-on: https://chromium-review.googlesource.com/806474 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#11} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/ui_texture.cc [modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/ui_texture.h [modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/url_bar_texture_unittest.cc [modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/ui_scene_creator.cc
,
Dec 4 2017
,
Dec 7 2017
Hi Brian, I'm wondering if there is a manual test case we missed or need to add here. WDYT? What is the exit warning?
,
Jan 8 2018
It probably doesn't make sense to add a manual test for this regression. I don't foresee a refactor which might again regress this. And we are about to have pixel test which should be able to catch this regression easily. So mark this one as fixed. We do need to make sure that pixel test cover "exit warning" ui though. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 2 2017