New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791159 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

The background and foreground color of exit warning screen regressed.

Project Member Reported by bshe@chromium.org, Dec 1 2017

Issue description

It looks like we forgot to set the colors through binding.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9165179ec998c264c5715c1c59f45c5155c23ddd

commit 9165179ec998c264c5715c1c59f45c5155c23ddd
Author: Biao She <bshe@chromium.org>
Date: Sat Dec 02 01:15:04 2017

Fix exit warning screen color regression


Bug:  791159 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idbc8b244d2f39c61eeaccf177cf306e4edc1ba4c
Reviewed-on: https://chromium-review.googlesource.com/804339
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521166}
[modify] https://crrev.com/9165179ec998c264c5715c1c59f45c5155c23ddd/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/9165179ec998c264c5715c1c59f45c5155c23ddd/chrome/browser/vr/elements/ui_texture.h
[modify] https://crrev.com/9165179ec998c264c5715c1c59f45c5155c23ddd/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/9165179ec998c264c5715c1c59f45c5155c23ddd/chrome/browser/vr/ui_scene_creator.cc

Labels: Merge-Request-64
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 3 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 4 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf56261d2837ed350243f4ae6d0632d9b9bdce9

commit 9cf56261d2837ed350243f4ae6d0632d9b9bdce9
Author: Biao She <bshe@chromium.org>
Date: Mon Dec 04 14:55:07 2017

Fix exit warning screen color regression

TBR=bshe@chromium.org

(cherry picked from commit 9165179ec998c264c5715c1c59f45c5155c23ddd)

Bug:  791159 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idbc8b244d2f39c61eeaccf177cf306e4edc1ba4c
Reviewed-on: https://chromium-review.googlesource.com/804339
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521166}
Reviewed-on: https://chromium-review.googlesource.com/806474
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#11}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/ui_texture.h
[modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/9cf56261d2837ed350243f4ae6d0632d9b9bdce9/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Hi Brian, I'm wondering if there is a manual test case we missed or need to add here. WDYT? What is the exit warning?

Comment 7 by bshe@chromium.org, Jan 8 2018

Status: Fixed (was: Assigned)
It probably doesn't make sense to add a manual test for this regression. I don't foresee a refactor which might again regress this. And we are about to have pixel test which should be able to catch this regression easily. So mark this one as fixed. We do need to make sure that pixel test cover "exit warning" ui though.

Sign in to add a comment