GOMA_DISABLED on Windows Outputs a Lot of Text |
||||
Issue descriptionRepro: C:\Chromium\src>set GOMA_DISABLED=true C:\Chromium\src>ninja -C out\Debug base_unittests Issue: Each compile build step spews error text: [ 1/141 - 6 processes @ 0.1/s : 7.172s ] CXX obj/base/base_unittests/important_file_writer_unittest.obj E1201 14:17:19.443200 5880 subprocess.cc:72] failed to get executable path. prog=../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe path=C:\Chromium\depot_tools;C:\Goma;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Users\Robert Liao\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Notepad++; pathext=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC [ 2/141 - 6 processes @ 0.3/s : 7.181s ] CXX obj/base/base_unittests/histogram_snapshot_manager_unittest.obj E1201 14:17:19.462203 5628 subprocess.cc:72] failed to get executable path. prog=../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe path=C:\Chromium\depot_tools;C:\Goma;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Users\Robert Liao\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Notepad++; pathext=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC On Mac, GOMA_DISABLED doesn't do this.
,
Dec 4 2017
Can you compile without use_goma=true? If so can I ask you to attach log from `goma_ctl.py report`?
,
Dec 4 2017
Reproduced. If GOMA_DISABLED is true, gomacc does not communicate with compiler_proxy, so compiler_proxy.INFO won't contain useful log. Also, gomacc log contains what robliao pasted. Anyway, the problem is gomacc tries executing "../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe" as is, however, '/' is not a valid path separator for Windows (usually). If '/' is converted to '\', it should work. ninja and compiler_proxy might convert '/' to '\', but gomacc is not doing it now?
,
Dec 4 2017
Sorry, I introduced this bug.
,
Dec 5 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/goma/client/+/39615dc2266d470d3555935b02e944c1ccc574c5 commit 39615dc2266d470d3555935b02e944c1ccc574c5 Author: Takuto Ikuta <tikuta@google.com> Date: Tue Dec 05 02:14:44 2017
,
Dec 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by robliao@chromium.org
, Dec 1 2017