New issue
Advanced search Search tips

Issue 791148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 640365

Blocking:
issue 896947



Sign in to add a comment

ZoomBubbleBrowserTest.ImmersiveFullscreen fails in browser_tests --mash

Project Member Reported by jamescook@chromium.org, Dec 1 2017

Issue description

Maybe some event filter isn't being created.

[151472:151472:1201/135952.467223:ERROR:immersive_handler_factory_mus.cc(19)] Not implemented reached in virtual std::unique_ptr<ash::ImmersiveFocusWatcher> ImmersiveHandlerFactoryMus::CreateFocusWatcher(ash::ImmersiveFullscreenController *)
[151472:151472:1201/135952.467240:ERROR:immersive_handler_factory_mus.cc(26)] Not implemented reached in virtual std::unique_ptr<ash::ImmersiveGestureHandler> ImmersiveHandlerFactoryMus::CreateGestureHandler(ash::ImmersiveFullscreenController *)
[151472:151472:1201/135952.469620:ERROR:immersive_context_mus.cc(59)] Not implemented reached in virtual bool ImmersiveContextMus::IsMouseEventsEnabled()
[1:10:1201/135952.481849:ERROR:layer_tree_host_impl.cc(2532)] Forcing zero-copy tile initialization as worker context is missing
[151472:151472:1201/135952.491526:ERROR:immersive_context_mus.cc(59)] Not implemented reached in virtual bool ImmersiveContextMus::IsMouseEventsEnabled()
../../chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc:129: Failure
Value of: immersive_controller->IsRevealed()
  Actual: false
Expected: true

 
Components: -Internals>MUS Internals>Services>WindowService

Comment 2 by e...@chromium.org, Mar 9 2018

Cc: -e...@chromium.org
Un-cc-ing me from all bugs on my final day.

Comment 3 by est...@chromium.org, Apr 11 2018

Blockedon: 640365
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Blocking: 896947
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7297063c2296370ca43d4c1e13f687cea12c11f8

commit 7297063c2296370ca43d4c1e13f687cea12c11f8
Author: Evan Stade <estade@chromium.org>
Date: Fri Oct 19 18:28:11 2018

Remove ZoomBubbleBrowserTest from Mash blacklists.

The suppression is obsolete and the tests already work.

Bug:  791148 
Change-Id: Ifc90e869376cc2833062ab54d32dd93c87f4ad3f
Reviewed-on: https://chromium-review.googlesource.com/c/1291786
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601231}
[modify] https://crrev.com/7297063c2296370ca43d4c1e13f687cea12c11f8/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/7297063c2296370ca43d4c1e13f687cea12c11f8/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Labels: Proj-Mash
Owner: est...@chromium.org
Status: Fixed (was: Untriaged)
Marking Fixed, thanks Evan.

Sign in to add a comment