New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791142 link

Starred by 1 user
Status: Fixed
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Feb 2018
Cc:
█ ericde@chromium.org
laforge@google.com
patricia...@chromium.org
█ mu...@chromium.org
rohi...@chromium.org
ihf@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

The Flash site settings option does not appear unless the user changes the default.

Project Member Reported by jecl...@adobe.com, Dec 1 2017 
Chrome Version: Version 64.0.3282.0 (Official Build) canary (64-bit)
OS: Win10

What steps will reproduce the problem?
(1) Go here: http://www.ecodazoo.com/
(2) Click the info icon to the the left of the URL

What is the expected result?
An option to Allow/Deny Flash content should be displayed

What happens instead?
No option to Allow/Deny Flash content is displayed.  
(You *can* choose the per-site settings option at the bottom, then set it via the classic menu.)

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
actual.PNG
64.4 KB View Download
Expected.PNG
445 KB View Download

Comment 1 by jecl...@adobe.com, Dec 1 2017 

Some Flash content uses JavaScript to detect the presence of Flash Player prior to adding the actual .SWF object to the document's DOM.  This wasn't a problem in previous versions of Chrome, because the Flash option was always there regardless of the actual DOM structure.  While the new feature strives to only show relevant controls, the inconsistent presence of Flash controls on content requiring Flash creates confusion for users.

Comment 2 by laforge@google.com, Dec 1 2017

Cc: ericde@chromium.org
Labels: -Pri-3 Pri-1
Owner: raymes@chromium.org
Status: Assigned (was: Untriaged)
Hey Raymes,

Given the current code base, how difficult would it be to keep Flash listed persistently?

Comment 3 by laforge@google.com, Dec 1 2017

Components: UI>Browser>Permissions>Prompts Internals>Plugins>Flash

Comment 4 by laforge@google.com, Dec 1 2017

Summary: The Flash site settings option does not appear unless the user changes the default. (was: Ecodazoo - Flash Allow/Deny options don't appear on some content)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c4d54d28b87c239af757e1ce9aefd71156504c

commit d7c4d54d28b87c239af757e1ce9aefd71156504c
Author: Patti <patricialor@chromium.org>
Date: Thu Dec 07 00:54:14 2017

Page Info Desktop: Always show the Flash permission.

Show the Flash permission always on desktop Page Info.

Bug:  791142 
Change-Id: I42dd4e856ce0818cea9905e36669a74cc54a6f98
Reviewed-on: https://chromium-review.googlesource.com/809987
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522281}
[modify] https://crrev.com/d7c4d54d28b87c239af757e1ce9aefd71156504c/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/d7c4d54d28b87c239af757e1ce9aefd71156504c/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/d7c4d54d28b87c239af757e1ce9aefd71156504c/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc

Comment 6 by patricia...@chromium.org, Dec 7 2017

Labels: Merge-Request-64 OS-Linux
Status: Started (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 8 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 11 2017

Cc: patricia...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by patricia...@chromium.org, Dec 12 2017 

Verified working in Canary 65.0.3292.0, will merge to 64 now.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d5a539c382980f9c2a71de03f7445698986188

commit 48d5a539c382980f9c2a71de03f7445698986188
Author: Patti <patricialor@chromium.org>
Date: Tue Dec 12 07:14:36 2017

Page Info Desktop: Always show the Flash permission.

Show the Flash permission always on desktop Page Info.

TBR=patricialor@chromium.org

(cherry picked from commit d7c4d54d28b87c239af757e1ce9aefd71156504c)

Bug:  791142 
Change-Id: I42dd4e856ce0818cea9905e36669a74cc54a6f98
Reviewed-on: https://chromium-review.googlesource.com/809987
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522281}
Reviewed-on: https://chromium-review.googlesource.com/822015
Reviewed-by: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#167}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/48d5a539c382980f9c2a71de03f7445698986188/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/48d5a539c382980f9c2a71de03f7445698986188/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/48d5a539c382980f9c2a71de03f7445698986188/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c57f37d2a383692a4bfa7e37e55303352258346

commit 8c57f37d2a383692a4bfa7e37e55303352258346
Author: Patti <patricialor@chromium.org>
Date: Wed Jan 31 04:33:21 2018

Desktop Page Info: Always show Flash if it has ever been changed for a site.

Since r522281, the Flash permission is always shown in the Page Info bubble.
This was a temporary measure to increase its discoverability after all
non-factory-default permissions were removed in r503089, but it isn't an ideal
solution - for example, it might imply that the site is using Flash when it
isn't.

Replace this with a more permanent solution - if the user has changed Flash
before on a particular site, always show Flash in that site's Page Info bubble.

Bug:  791142 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5bd7ee74cffeee8fe87743b9c0d7336021c52da0
Reviewed-on: https://chromium-review.googlesource.com/858245
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533201}
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/plugins/plugin_utils.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/plugins/plugin_utils.h
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/components/content_settings/core/browser/host_content_settings_map.h
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/8c57f37d2a383692a4bfa7e37e55303352258346/components/content_settings/core/common/content_settings_types.h

Comment 12 by patricia...@chromium.org, Feb 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment