New issue
Advanced search Search tips

Issue 791139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

drag-region screenshots are very incorrect after a right-click

Reported by marcelfr...@gmail.com, Dec 1 2017

Issue description

Chrome Version       : 62.0.3202.94
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: N/A
    Firefox: N/A
    IE/Edge: N/A

What steps will reproduce the problem?
1.Open the chrome Dev tools with Ctrl+Shift+C
2.Hold down the Ctrl key and drag a portion of the screen to take a screenshot.
3.Instead of releasing the left mouse button, click the right mouse button and then release the left mouse button.

What is the expected result?
My thought process for this is, that it would cancel the screenshot action.

What happens instead of that?
HTML is unrendered (white screen), the dev tools still show the HTML but when hovering over the elements in the elements tab, there is no indication on screen. Which is logical if there is no rendered HTML. After a while the HTML is rendered again and the screenshot is still made (with some weird misplaced semi-rendered elements).

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

screenshot-1.png - different size image than initial selection of webpage: https://developers.google.com/web/updates/2017/08/devtools-release-notes#screenshots

screenshot-2.png - different selection size, but exactly the same rendered image size as the other image on webpage: some stream on twitch.tv
 
screenshot-1.png
23.3 KB View Download
screenshot-2.png
26.3 KB View Download
Cc: rkalavakuntla@chromium.org
Components: Platform>DevTools
Labels: -Pri-3 M-64 Needs-Triage-M62 OS-Linux Pri-2
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Win-7 and Ubuntu 14.04 using the chrome reported version #62.0.3202.94 and canary #64.0.3282.5 by the steps mentioned in Comment #1.
Attached is the screencast for reference..

This is a New feature implemented for Devtools in M-62.Hence,considering the issue as Non-Regression issue from M-62 and marking it as untriaged for further update from dev team.
Thanks..
791139.webm
967 KB View Download
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Summary: drag-region screenshots are very incorrect after a right-click (was: New screenshot feature bug.)
I can repro this. Yeah the screenshots look really messed up if you right-click before you left-click.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74485beee0cb47708f8ffc7560b53139ab5278de

commit 74485beee0cb47708f8ffc7560b53139ab5278de
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 10 23:21:21 2018

[DevTools] Fix area screenshot issues

- Minimum size is set to 5x5 pixels.
- Non-left button clicks reset the screenshot mode.

Bug:  791139 ,  789962 
Change-Id: I748ef50a8068617204e574d5e7fb1e3284cc09af
Reviewed-on: https://chromium-review.googlesource.com/c/1368659
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615308}
[modify] https://crrev.com/74485beee0cb47708f8ffc7560b53139ab5278de/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc

Labels: TE-Verified-M73 TE-Verified-73.0.3637.0
Verified the fix on Ubuntu 17.10 and Windows-10 using Chrome version 73.0.3637.0 as per the comment #0.
Attaching screen cast for reference.
Didn't observe any issues with drag-region screenshots.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!



Dec 11, 2018 5_37 PM.webm
4.4 MB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment