New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791131 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

TestError: Media.RTCVideoDecoderInitDecodeSucces not loaded or histogram bucket not found or histogram bucket found at < 100% on PFQ

Project Member Reported by osh...@chromium.org, Dec 1 2017

Issue description

This started on Nov 30, although this could have been sealed by other issues.

Following pfq bots are having this issue:

peach_pit-chrome-pfq
peach_pit-tot-chrome-pfq-informational
caroline-tot-chrome-pfq-informational
veyron_minnie-tot-chrome-pfq-informational


Looks like we've been having the same issue once a while and goes away?

https://bugs.chromium.org/p/chromium/issues/list?can=1&q=RTCVideoDecoderInitDecodeSucces&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids

Steven, have you seen this before?


12/01 09:05:58.436 DEBUG|      global_hooks:0056| 'logger "autotest finished iteration /usr/local/autotest/results/default/video_ChromeRTCHWDecodeUsed.vp8/sysinfo/iteration.1"'
12/01 09:05:58.467 DEBUG|              test:0420| after_iteration_hooks completed
12/01 09:05:58.469 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/cros/video/helper_logger.py", line 82, in call
    return func(*args, **kwargs)
  File "/usr/local/autotest/tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py", line 81, in run_once
    histogram_verifier.verify(cr, histogram_name, histogram_bucket_val)
  File "/usr/local/autotest/cros/video/histogram_verifier.py", line 72, in verify
    sleep_interval=1)
  File "/usr/local/autotest/common_lib/utils.py", line 2740, in poll_for_condition
    raise exception
TestError: Media.RTCVideoDecoderInitDecodeSucces not loaded or histogram bucket not found or histogram bucket found at < 100%

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: xixuan@chromium.org
looks like rsync is failing. xixuan@, do you have any idea why this is failing?


12/01 09:05:59.295 DEBUG|      global_hooks:0056| 'mkdir -p /usr/local/autotest/results/default/video_ChromeRTCHWDecodeUsed.vp8/sysinfo/var'
12/01 09:05:59.314 DEBUG|             utils:0212| Running 'rsync --no-perms --chmod=ugo+r -a --safe-links --exclude=/log/**autoserv* /var/log /usr/local/autotest/results/default/video_ChromeRTCHWDecodeUsed.vp8/sysinfo/var'
12/01 09:05:59.315 DEBUG|      global_hooks:0056| 'rsync --no-perms --chmod=ugo+r -a --safe-links --exclude=/log/**autoserv* /var/log /usr/local/autotest/results/default/video_ChromeRTCHWDecodeUsed.vp8/sysinfo/var'
12/01 09:05:59.466 INFO |              test:0928| after_hook completed
12/01 09:05:59.468 ERROR|          parallel:0026| child process failed
12/01 09:05:59.484 DEBUG|          parallel:0030| Traceback (most recent call last):
12/01 09:05:59.485 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/parallel.py", line 18, in fork_start
12/01 09:05:59.485 DEBUG|          parallel:0030|     l()
12/01 09:05:59.485 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/job.py", line 488, in <lambda>
12/01 09:05:59.486 DEBUG|          parallel:0030|     l = lambda : test.runtest(self, url, tag, args, dargs)
12/01 09:05:59.486 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/test.py", line 117, in runtest
12/01 09:05:59.487 DEBUG|          parallel:0030|     job.sysinfo.log_after_each_iteration)
12/01 09:05:59.487 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 919, in runtest
12/01 09:05:59.488 DEBUG|          parallel:0030|     mytest._exec(args, dargs)
12/01 09:05:59.488 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
12/01 09:05:59.488 DEBUG|          parallel:0030|     _call_test_function(self.execute, *p_args, **p_dargs)
12/01 09:05:59.489 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
12/01 09:05:59.489 DEBUG|          parallel:0030|     return func(*args, **dargs)
12/01 09:05:59.489 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 495, in execute
12/01 09:05:59.490 DEBUG|          parallel:0030|     dargs)
12/01 09:05:59.490 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
12/01 09:05:59.491 DEBUG|          parallel:0030|     postprocess_profiled_run, args, dargs)
12/01 09:05:59.491 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
12/01 09:05:59.491 DEBUG|          parallel:0030|     self.run_once(*args, **dargs)
12/01 09:05:59.492 DEBUG|          parallel:0030|   File "/usr/local/autotest/cros/video/helper_logger.py", line 82, in call
12/01 09:05:59.492 DEBUG|          parallel:0030|     return func(*args, **kwargs)
12/01 09:05:59.493 DEBUG|          parallel:0030|   File "/usr/local/autotest/tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py", line 81, in run_once
12/01 09:05:59.493 DEBUG|          parallel:0030|     histogram_verifier.verify(cr, histogram_name, histogram_bucket_val)
12/01 09:05:59.493 DEBUG|          parallel:0030|   File "/usr/local/autotest/cros/video/histogram_verifier.py", line 72, in verify
12/01 09:05:59.494 DEBUG|          parallel:0030|     sleep_interval=1)
12/01 09:05:59.494 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/utils.py", line 2740, in poll_for_condition
12/01 09:05:59.494 DEBUG|          parallel:0030|     raise exception
12/01 09:05:59.495 DEBUG|          parallel:0030| TestError: Media.RTCVideoDecoderInitDecodeSucces not loaded or histogram bucket not found or histogram bucket found at < 100%
Cc: hiroh@chromium.org ihf@chromium.org
I've seen this *symptom* before, however it is not very indicitive of the actual problem.

See  issue 782539  for discussion and a specific fix (that clearly didn't fix this particular failure).

It's not rsync failing. The 'rsync' command is part of 'after_hooks', whose use is to collect some host info after a test is finished. Logging '12/01 09:05:59.466 INFO |              test:0928| after_hook completed' means it's successfully finished.

The failure traceback gets printed after it because we print traceback at the very end of a test, so logging is after 'after_hooks'. You can check https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/159660017-chromeos-test/chromeos6-row2-rack10-host22/debug/client.0.DEBUG for more details.

Comment 4 by ihf@chromium.org, Dec 1 2017

Cc: kcwu@chromium.org posciak@chromium.org
Components: OS>Kernel>Video
This means hardware decode in the new Chrome is broken.

Blindly rethrowing internal Chrome exception without catching them and converting them into a human readable TestFail: causes confusion like this. The test needs improvement!
Owner: posciak@chromium.org
Thanks, I'll update the control.y4m for now. Pawel, could you please look into this?
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/831142bdf8795b7e6f77f4ca245da3f381da0c9d

commit 831142bdf8795b7e6f77f4ca245da3f381da0c9d
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Dec 02 01:26:18 2017

Skip video_ChromeRTCHWDecodedUsed HWTest in CQ

BUG= chromium:791131 
TEST=None

Change-Id: I7e6daef0bf41b46a835971187c41f4022fbab3d7
Reviewed-on: https://chromium-review.googlesource.com/804641
Trybot-Ready: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/831142bdf8795b7e6f77f4ca245da3f381da0c9d/client/site_tests/video_ChromeRTCHWDecodeUsed/control.y4m

Cc: acourbot@chromium.org jcliang@chromium.org
Owner: mojahsu@chromium.org
+Ricky, Moja, Alex

Is this related to  http://crbug.com/790838  or  http://crbug.com/790904 ?
Labels: -Pri-3 Pri-2
Labels: -Pri-2 Pri-1

Comment 11 by ihf@chromium.org, Dec 4 2017

Cc: x...@chromium.org sammiequon@chromium.org
Labels: -Pri-1 Pri-2
Please file a new video issue for video_VideoEncodeAccelerator. Notice it doesn't block Chrome uprev or cq as tests are only in bvt-perbuild.

Lowering priority, waiting for revert of change in #6 to go through cq. Then close.
There is already an issue for video_VideoEncodeAccelerator  crbug.com/790904 .
The failure is expected to be fixed if crrev.com/c/802669 is landed.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e98da507f70538bcf5a3d0934f895c3781fd31c

commit 6e98da507f70538bcf5a3d0934f895c3781fd31c
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Tue Dec 05 04:02:57 2017

Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ"

This reverts commit 831142bdf8795b7e6f77f4ca245da3f381da0c9d.

Test passes again.

BUG= chromium:791131 
TEST=cq will test

Change-Id: Ib3e1976021481e9c4fc6891c998ac42cb543e9a1
Reviewed-on: https://chromium-review.googlesource.com/805458
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/6e98da507f70538bcf5a3d0934f895c3781fd31c/client/site_tests/video_ChromeRTCHWDecodeUsed/control.y4m

Comment 14 by ihf@chromium.org, Dec 5 2017

Status: WontFix (was: Assigned)
Fix unknown.

Comment 15 by x...@chromium.org, Dec 5 2017

Status: Assigned (was: WontFix)
The same failure shows up on the informational builds again after the revert CL in #13.

Comment 16 by x...@chromium.org, Dec 5 2017

I'll revert the CL in #13 to unblock the PFQ first.
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/19d29ea617df917ca0ef514c5738742da2e33b9a

commit 19d29ea617df917ca0ef514c5738742da2e33b9a
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Dec 05 19:51:13 2017

Revert "Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ""

This reverts commit 6e98da507f70538bcf5a3d0934f895c3781fd31c.

Reason for revert: PFQ informational builds failed again. Revert it first while investigating what might be the cause.

Original change's description:
> Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ"
> 
> This reverts commit 831142bdf8795b7e6f77f4ca245da3f381da0c9d.
> 
> Test passes again.
> 
> BUG= chromium:791131 
> TEST=cq will test
> 
> Change-Id: Ib3e1976021481e9c4fc6891c998ac42cb543e9a1
> Reviewed-on: https://chromium-review.googlesource.com/805458
> Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
> Tested-by: Ilja H. Friedel <ihf@chromium.org>
> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

Bug:  chromium:791131 
Change-Id: I2644812d057d7ccc90750418e647be06f87ad26e
Reviewed-on: https://chromium-review.googlesource.com/809308
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Tested-by: Xiaoqian Dai <xdai@chromium.org>
Tested-by: Mitsuru Oshima <oshima@chromium.org>

[modify] https://crrev.com/19d29ea617df917ca0ef514c5738742da2e33b9a/client/site_tests/video_ChromeRTCHWDecodeUsed/control.y4m

Comment 18 by x...@chromium.org, Dec 5 2017

Labels: -Pri-2 Build-PFQ-Failures Pri-1
Owner: magjed@chromium.org
Bisecting shows that https://chromium-review.googlesource.com/788410 is the CL that caused the failure. Assign to the owner for investigation.
magjed@, please take a look.
Thanks for bisecting.
If it occurs only on ChromeOS and the CL owners don't get the reason, I can help.

Comment 20 by x...@chromium.org, Dec 6 2017

Cc: magjed@chromium.org
Owner: hiroh@chromium.org
Thank you for the help hiroh@!
I'll assign to you now to start investigation as the owner is in a different time zone and it's night time there. 
OK. I try to fix from now.
We have .mjpeg and .y4m tests in video_ChromeRTCHWDecodeUsed.
In mjpeg test, it checks the histogram whose name is "Media.VideoCaptureGpuJpegDecoder.InitDecodeSuccess."
In y4m test, it checks the histogram whose name is "Media.RTCVideoDecoderInitDecodeSucces."
The latter is marked in https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_decoder.cc?q=RTCVideoDecoderInitDecodeSucces&dr=C&l=882.
This test is failed because it doesn't reach there in y4m test.
I don't know the code and mechanism around here well.
At least, HW acceleration is disabled for webrtc.
Thanks to https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_decoder_factory.cc?l=71, external_decoder(i.e. HW accelerated decoder) is always nullptr. https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/video_codec_factory.cc?q=video_codec_factory.cc&dr&l=147

However, internal decoder(i.e. software decoder) is always created. So it seems
 to me that rtc_video_decoder::InitDecode should be called and the histogram is initialized.

I still continue investigating.
internal decoder is a software decoder in /third_party/webrtc. https://cs.chromium.org/chromium/src/third_party/webrtc/api/video_codecs/video_decoder.h?sq=package:chromium&l=59
So when using it, rtc_video_decoder isn't used at all.
This and comment#22 explain the test failure.

Our team suppose the test to test WebRTC using HW acceleration.
So checking the histogram value is not a wrong way.

Therefore, I would like to change as HW decoder is used if it is enabled.
That is doing this TODO. https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_decoder_factory.cc?l=72

Comment 24 Deleted

video_ChromeRTCHWDecodeUsed for y4m is to check if HW decode acceleration is used.
After this CL https://chromium-review.googlesource.com/788410, HW acceleration cannot be available for webrtc, because the code says no format is supported.
https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_decoder_factory.cc?l=72.
To fix this, we need to do TODO there.

@magjed, can you address this ASAP?

Thanks.
Labels: ReleaseBlock-Dev M-64 M-65 videoshortlist
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17713f13039dc90bb1ee390f370250af2f42157c

commit 17713f13039dc90bb1ee390f370250af2f42157c
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Wed Dec 06 10:16:07 2017

Revert "WebRTC: Migrate completely to new video codec factories API"

This reverts commit c47b4d110a697afa6a6ee4d4748028312c65ec19.

BUG= chromium:791131 
TEST=video_ChromeRTCHWDecodeUsed on peach_pit
Reason for revert: This CL breaks video_ChromeRTCHWDecodeUsed

Original change's description:
> WebRTC: Migrate completely to new video codec factories API
> 
> This CL makes the Chromium HW video factories implement the new
> interfaces directly. It also adds SW codecs, simulcast, and SW fallback
> codecs manually, instead of relying on WebRTC to do this. This will
> give Chromium more flexibility in the future, and will allow us to
> simplify the WebRTC code, since it's only Chromium that uses some of
> these features.
> 
> Bug:  webrtc:7925 
> Change-Id: I2bbd8b9a8c52bfe963d601f34188faf47d59e67e
> Reviewed-on: https://chromium-review.googlesource.com/788410
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Commit-Queue: Magnus Jedvert <magjed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520062}

TBR=haraken@chromium.org,emircan@chromium.org,magjed@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  webrtc:7925 
Change-Id: I081f9f5d961707924fe6eed4a97ead9c9f5ed12c
Reviewed-on: https://chromium-review.googlesource.com/810429
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522056}
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/BUILD.gn
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_decoder.h
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_decoder_factory.cc
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_decoder_factory.h
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_encoder.cc
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_encoder.h
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_encoder_factory.cc
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/gpu/rtc_video_encoder_factory.h
[modify] https://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[delete] https://crrev.com/3f2dd6b5d9db503563c2cd8a6e79b79b09075d87/content/renderer/media/webrtc/video_codec_factory.cc
[delete] https://crrev.com/3f2dd6b5d9db503563c2cd8a6e79b79b09075d87/content/renderer/media/webrtc/video_codec_factory.h

Labels: Merge-Request-64
May I please to request merging the CL in comment#27?

Thanks.
Project Member

Comment 29 by sheriffbot@chromium.org, Dec 6 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi all, I'm planning a M64 DEV RC today and it's not clear how blocking this is and which specific boards are impacted.  I picked up a newer Chrome overnight per activities beforehand.   Assume good to go with today's DEV RC?
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.

Comment 32 by x...@chromium.org, Dec 6 2017

Thanks hiroh@! I'll merge the revert CL in #27 to M64.
Project Member

Comment 33 by bugdroid1@chromium.org, Dec 6 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d220754b28456473f49e78bda4121fb2f04aed

commit 15d220754b28456473f49e78bda4121fb2f04aed
Author: xdai <xdai@chromium.org>
Date: Wed Dec 06 18:40:01 2017

[Merge to M64]Revert "WebRTC: Migrate completely to new video codec factories API"

This reverts commit c47b4d110a697afa6a6ee4d4748028312c65ec19.

BUG= chromium:791131 
TEST=video_ChromeRTCHWDecodeUsed on peach_pit
Reason for revert: This CL breaks video_ChromeRTCHWDecodeUsed

Original change's description:
> WebRTC: Migrate completely to new video codec factories API
>
> This CL makes the Chromium HW video factories implement the new
> interfaces directly. It also adds SW codecs, simulcast, and SW fallback
> codecs manually, instead of relying on WebRTC to do this. This will
> give Chromium more flexibility in the future, and will allow us to
> simplify the WebRTC code, since it's only Chromium that uses some of
> these features.
>
> Bug:  webrtc:7925 
> Change-Id: I2bbd8b9a8c52bfe963d601f34188faf47d59e67e
> Reviewed-on: https://chromium-review.googlesource.com/788410
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Commit-Queue: Magnus Jedvert <magjed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520062}

TBR=haraken@chromium.org,emircan@chromium.org,magjed@chromium.org


(cherry picked from commit 17713f13039dc90bb1ee390f370250af2f42157c)

Bug:  webrtc:7925 
Change-Id: I081f9f5d961707924fe6eed4a97ead9c9f5ed12c
Reviewed-on: https://chromium-review.googlesource.com/810429
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522056}
Reviewed-on: https://chromium-review.googlesource.com/811664
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#61}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/BUILD.gn
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_decoder.h
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_decoder_factory.cc
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_decoder_factory.h
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_encoder.cc
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_encoder.h
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_encoder_factory.cc
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/gpu/rtc_video_encoder_factory.h
[modify] https://crrev.com/15d220754b28456473f49e78bda4121fb2f04aed/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[delete] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/content/renderer/media/webrtc/video_codec_factory.cc
[delete] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/content/renderer/media/webrtc/video_codec_factory.h

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Changing this to a beta blocker rather than dev since we expect this to be a performance issue rather than a functionality fail.   Please weigh in if not the case; we assume encoding will continue to happen via software.
Owner: hiroh@chromium.org
Thank you!


kbleicher@: Not blocking dev sgtm, however was the dev cut before the revert went in (http://crrev.com/17713f13039dc90bb1ee390f370250af2f42157c)?


hiroh@: With the reverts in, we should be able to re-enable video_ChromeRTCHWDecodedUsed in CQ (i.e. revert https://chromium-review.googlesource.com/c/809308/)? Would you be able to confirm please? Thank you.
Labels: -merge-merged-3282
The "webrtc" revert CL is landed after 65.0.3287.0.
The current Chrome on ChromeOS is 65.0.3286.0.
So I will test video_CHromeRTCHWDecodeUsed later.
I create a CL for reverting "video_ChromeRTCHWDecodeUsed" in advance though. https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/813134

Comment 37 by x...@chromium.org, Dec 7 2017

I think the revert CL was merged into M64, see comment#33. 
Yep, this made the merge to 64.0.3282.14 which was in yesterday's DEV RC.  Can we tag as fixed?
Yep, this made the merge to 64.0.3282.14 which was in yesterday's DEV RC.  Can we tag as fixed?
I am trying to land a CL to run video_ChromeRTCHWDecodeUsed in CQ on M65.
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/813134

Should we land this CL to M64 as well?
Labels: -Hotlist-Merge-Review -ReleaseBlock-Beta Merge-Request-64
May I please to merge this CL in M64 as well?
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/813134

Thanks.
Project Member

Comment 42 by sheriffbot@chromium.org, Dec 8 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Labels: -Hotlist-Merge-Review -M-64 -Merge-Approved-64
ChromeRTCHWDecodeUsed test is in CQ on M64 branch.
So we don't need to (couldn't) submit the same CL as https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/813134.
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b559c06b758c442d83f70c0b812d00e7ae5ffd8a/client/site_tests/video_ChromeRTCHWDecodeUsed/control.y4m

So let us mark fixed after the above CL will be landed on M65 branch.

Thanks.
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df4faa2a4e3963496209146c48f1010949d66d77

commit df4faa2a4e3963496209146c48f1010949d66d77
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Fri Dec 08 11:59:22 2017

Reland "Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ""

This reverts commit 19d29ea617df917ca0ef514c5738742da2e33b9a.

Reason for revert: The test should be passed now.

Original change's description:
> Revert "Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ""
>
> This reverts commit 6e98da507f70538bcf5a3d0934f895c3781fd31c.
>
> Reason for revert: PFQ informational builds failed again. Revert it first while investigating what might be the cause.
>
> Original change's description:
> > Revert "Skip video_ChromeRTCHWDecodedUsed HWTest in CQ"
> >
> > This reverts commit 831142bdf8795b7e6f77f4ca245da3f381da0c9d.
> >
> > Test passes again.
> >
> > BUG= chromium:791131 
> > TEST=cq will test
> >
> > Change-Id: Ib3e1976021481e9c4fc6891c998ac42cb543e9a1
> > Reviewed-on: https://chromium-review.googlesource.com/805458
> > Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
> > Tested-by: Ilja H. Friedel <ihf@chromium.org>
> > Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
>
> Bug:  chromium:791131 
> Change-Id: I2644812d057d7ccc90750418e647be06f87ad26e
> Reviewed-on: https://chromium-review.googlesource.com/809308
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Tested-by: Xiaoqian Dai <xdai@chromium.org>
> Tested-by: Mitsuru Oshima <oshima@chromium.org>

Bug:  chromium:791131 
Change-Id: Ib3622e56b240d34caedd6499d87a47364b05c184
Reviewed-on: https://chromium-review.googlesource.com/813134
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>

[modify] https://crrev.com/df4faa2a4e3963496209146c48f1010949d66d77/client/site_tests/video_ChromeRTCHWDecodeUsed/control.y4m

Status: Fixed (was: Assigned)
Cc: avkodipelli@chromium.org vsu...@chromium.org
Status: Verified (was: Fixed)
Started running in bvt-cq

Sign in to add a comment