Move VR metrics to be cross-platform |
||||||||||
Issue descriptionVR metrics are mostly in the Android directory. Much of that code is cross-platform, but just lives in the wrong location. We should move it to a cross-platform location so it can be shared with Windows. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report. Note that this bug is branched from crbug/782865, which was re-purposed for just vrviewertype metric.
,
Dec 1 2017
,
Dec 7 2017
+cc tibor for metrics related bug. We recently have some metrics related refactor. Is this bug still make sense?
,
Dec 7 2017
Thanks for cc'ing! There is still the vr_shell::SessionTime and vr_shell::VrMetricsHelper of which at least parts could be made cross platform IMO.
,
Dec 8 2017
,
Dec 8 2017
Marking as started, as I have uploaded an initial CR. https://chromium-review.googlesource.com/c/chromium/src/+/784095
,
Jan 18 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9446f93e69c325b20ca44555d9bc410b67196a commit 1d9446f93e69c325b20ca44555d9bc410b67196a Author: Anna Offenwanger <offenwanger@chromium.org> Date: Mon Mar 12 21:30:32 2018 Refactoring VR usage monitor to make crossplatform use feasible Bug: 791130 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7d9ab135ce43d7670b04083437889caacad93874 Reviewed-on: https://chromium-review.googlesource.com/949052 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#542603} [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/assets_loader.cc [rename] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/metrics/metrics_helper.cc [rename] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/metrics/metrics_helper.h [rename] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/metrics/session_metrics_helper.cc [rename] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/metrics/session_metrics_helper.h [rename] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/browser/vr/metrics/session_metrics_helper_unittest.cc [modify] https://crrev.com/1d9446f93e69c325b20ca44555d9bc410b67196a/chrome/test/BUILD.gn
,
Mar 21 2018
,
Mar 21 2018
Marking as fixed - the code now lives in a cross-platform location. Many of the VR metrics are triggered in cross-platform or multiple locations, and we'll continue to add new ones and move existing metrics out as part of metrics cleanup.
,
Mar 23 2018
,
Jul 4
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by billorr@chromium.org
, Dec 1 2017