New issue
Advanced search Search tips

Issue 791125 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PolicyPrefsTest.PolicyToPresMapping test is not run on future policies

Project Member Reported by pastarmovj@chromium.org, Dec 1 2017

Issue description

This test is only run for policies that are marked for a given release after the VERSION file is uprevved to this version.

This caused recently two issues with a major uprev:

https://chromium-review.googlesource.com/c/chromium/src/+/804314

We have to find some way to make this policy test that or fail immediately if not specified correct.

 
Julian, who would be a good owner to drive this? 
I'm asking because it appears on our Enterprise Triage list.
Cc: -pastarmovj@chromium.org
Labels: Enterprise-Triaged
Owner: pastarmovj@chromium.org
Status: Started (was: Available)
already in the driver's seat :)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc83068a1a48063f983b67fbdfffb3aca8c80f3

commit abc83068a1a48063f983b67fbdfffb3aca8c80f3
Author: Julian Pastarmov <pastarmovj@chromium.org>
Date: Wed Dec 06 14:50:25 2017

Make it impossible to have non-matching policy_test_cases.json entries.

There were a few cases where due to mismatch between policy defintions
and entries in the policy_tests_cases.json file. The tests have failed
when Chrome was uprevved. This CL aims at making this a little harder
by enforcing a proper match between policy lifetime and their tests.

BUG:  791125 
TEST: browser_tests.exe --gtest_filter=PolicyPrefsTest.PolicyToPrefsMapping
Change-Id: I75fdef47081c27184c05ded7cd2bc6a3e355ac79
Reviewed-on: https://chromium-review.googlesource.com/808184
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522083}
[modify] https://crrev.com/abc83068a1a48063f983b67fbdfffb3aca8c80f3/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/abc83068a1a48063f983b67fbdfffb3aca8c80f3/chrome/test/data/policy/policy_test_cases.json

Status: Fixed (was: Started)

Sign in to add a comment