Remove the friend class of the test in OfflinePageModelTaskified |
||
Issue descriptionCurrently the OPMTaskifiedTest class is a friend of the OPMTaskified, we should probably remove it and expose those methods used in test by public APIs, then make corresponding changes to the tests.
,
May 30 2018
I'm not sure if this has to be done, since in the code base there are instances that friend class is used for writing unit tests. Also it's mentioned in the C++ style guide: https://google.github.io/styleguide/cppguide.html#Friends
,
May 30 2018
Personally I would prefer not to remove the friend class (it was a request mentioned in a CL comment)
,
Jun 1 2018
And according to the code search, we're using friend for writing unit tests. https://cs.chromium.org/search/?q=friend+file:%5Esrc/components/offline_pages/+package:%5Echromium$&type=cs I'm marking this bug as won't fix, and remove the TODO label in the code. |
||
►
Sign in to add a comment |
||
Comment 1 by dim...@chromium.org
, Feb 7 2018Status: Assigned (was: Available)