New issue
Advanced search Search tips

Issue 791112 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS][Security Review] Hide/blur out content when the app is put into the background

Project Member Reported by yuweih@chromium.org, Dec 1 2017

Issue description

Per security review, we should be cautious and blur out the content when the app is put into the background, to prevent data leak in the unencrypted app screenshots iOS takes to do animations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b8534442d2f4d242e088dca97e429ee37b88c8f

commit 2b8534442d2f4d242e088dca97e429ee37b88c8f
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Dec 05 01:15:47 2017

[CRD iOS] Blur remote host content when going to background

This CL adds a blur view to the HostView when the app becomes inactive
(transitioning to background, etc.) and removes it when the app becomes
active again.

Screenshot: https://drive.google.com/open?id=1UrWMUc-j0rRS-DQJ5zLLZ4_dTGgLohVr

Bug:  791112 
Change-Id: Ic66c57c939bb607ad7b740cb8112bd449cd20d45
Reviewed-on: https://chromium-review.googlesource.com/807402
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521567}
[modify] https://crrev.com/2b8534442d2f4d242e088dca97e429ee37b88c8f/remoting/ios/app/host_view_controller.mm

Labels: -M-65 Merge-Request-64
This only affects the Chrome Remote Desktop for iOS app and doesn't affect Chrome.

Comment 3 by cmasso@google.com, Dec 5 2017

Labels: -Merge-Request-64 Merge-Approved-64
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e8793beeed8e2862d83307a3f6dbf1e00708da

commit 08e8793beeed8e2862d83307a3f6dbf1e00708da
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Dec 05 19:54:34 2017

[CRD iOS] Blur remote host content when going to background

This CL adds a blur view to the HostView when the app becomes inactive
(transitioning to background, etc.) and removes it when the app becomes
active again.

Screenshot: https://drive.google.com/open?id=1UrWMUc-j0rRS-DQJ5zLLZ4_dTGgLohVr

Bug:  791112 
Change-Id: Ic66c57c939bb607ad7b740cb8112bd449cd20d45
Reviewed-on: https://chromium-review.googlesource.com/807402
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521567}(cherry picked from commit 2b8534442d2f4d242e088dca97e429ee37b88c8f)
Reviewed-on: https://chromium-review.googlesource.com/809389
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#36}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/08e8793beeed8e2862d83307a3f6dbf1e00708da/remoting/ios/app/host_view_controller.mm

Comment 5 by yuweih@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment