New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791097 link

Starred by 1 user
Status: Fixed
Owner:
█ lalitm@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
ssid@chromium.org
█ mariakho...@chromium.org
primiano@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Support dump for a single process

Project Member Reported by mariakho...@chromium.org, Dec 1 2017 
For previews, we have discussed reporting a specific renderer's memory on demand. In order not to do extra computation for a global dump when we only need one process, the proposal is to expose a method RequestGlobalDumpForPid(pid), so that we can get data for just one renderer.

Comment 1 by mariakho...@chromium.org, Dec 1 2017

Components: Internals>Instrumentation>Memory
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b99759e84d8a507313d20014205c3db3484b72a

commit 4b99759e84d8a507313d20014205c3db3484b72a
Author: “Lalit <lalitm@chromium.org>
Date: Mon Jan 08 11:36:13 2018

memory-infra: support global memory dumps for a single process

Often we will want to dump the memory information about a single process.
Up until this point, we would have had to ask every process and filter
after receiving all the data.

Add an API whch is able to generate a global dump while only requesting
data from a single process.

This CL also includes other misc changes to do with callbacks which were
appearing as presubmit warnings.

Bug:  791097 
Change-Id: I723031db36f9330b912e31da0b63e98d4583805c
Reviewed-on: https://chromium-review.googlesource.com/809204
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527609}
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/queued_request.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.h
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/4b99759e84d8a507313d20014205c3db3484b72a/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom

Comment 3 by lalitm@chromium.org, Jan 8 2018

Cc: mariakho...@chromium.org
Status: Fixed (was: Assigned)
The above commit should implements the described API so this bug should be fixed :)
►

Sign in to add a comment