New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791093 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Codesearch no longer displays inheritance or instantiation relationships

Project Member Reported by rdsmith@chromium.org, Dec 1 2017

Issue description

Going to https://cs.chromium.org/chromium/src/net/cookies/cookie_monster.h?type=cs&l=59 and clicking on the "CookieMonster" classname, the only categories of XRefs I get are "Definitions" and "References".  Codesearch used to display instantiations of classes, as well as inheritance relationships (CookieMonster inherits from CookieStore, for instance).  Is this a bug or is it intentional?  It's a little unfortunate; I've been trying to track instantiations recently, and searching through the references for them can be a pain.

 
Cc: emso@chromium.org
Labels: -Pri-3 Pri-1
+emso is this an expected or unexpected loss due to switching to kythe?

Comment 2 by emso@chromium.org, Dec 4 2017

Status: Available (was: Untriaged)
As far as I know there should not be any loss like this with the switch. Kythe should be the same and more. Sending an email to check this out with the Kythe team.
The "References" section contains instantiations, so those are all still there. I don't think there's a way to separate out instantiations vs non-instantiation references, but we'll ask.

The inheritance relationships are available in the XRef database, but it looks like the frontend isn't requesting them properly. Looking into a small change for that.

Comment 4 by emso@chromium.org, Dec 4 2017

Cc: -emso@chromium.org flyboy@chromium.org aga...@chromium.org
Owner: emso@chromium.org
Status: Assigned (was: Available)

Comment 5 by emso@chromium.org, Dec 4 2017

Looks like Kythe has more refined edge kinds and that is causing some things to be dropped if they are not explicitly asked for. We can add more specific requests to the frontend and I'll be looking into that.

Comment 6 by emso@chromium.org, Dec 5 2017

Fix for the inheritance issue has been submitted. As soon as the release is ready I'll push it out to staging then further on to prod if things look good.

After the release, I'll continue to investigate the instantiation list feature.

Comment 8 by emso@chromium.org, Dec 6 2017

The improved support for inheritance is released to prod: https://cs.chromium.org/chromium/src/net/cookies/cookie_store.h?type=cs&l=34
Thank you!

(Keeping my fingers crossed around separation out of instantiation still; that was useful.)

Comment 10 by emso@chromium.org, Dec 13 2017

Status: Verified (was: Assigned)
After more investigation it appears that the new Kythe index doesn't include instantiation information, so unfortunately we can't expand on what we ask the Kythe service for in this case. 

The only option left is to try to filter out instantiations from the list of references and I'm not sure if we have all the information need to do that with good accuracy. I created https://bugs.chromium.org/p/chromium/issues/detail?id=794565 to further track this issue.

Sign in to add a comment