New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791087 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

vr_pixeltests UiPixelTest.DrawVrBrowsingMode always crashing on VR Linux builder

Project Member Reported by aluo@chromium.org, Dec 1 2017

Issue description

Looks like shader version needs to be updated here:
https://codesearch.chromium.org/chromium/src/chrome/browser/vr/vr_gl_util.h?type=cs&q=OEIE_SHADER&l=17


[ RUN      ] UiPixelTest.DrawVrBrowsingMode
[5124:5124:1127/153355.124985:5124424269:ERROR:gl_surface_glx.cc(409)] XOpenDisplay failed.
[5124:5124:1127/153355.125013:5124424296:ERROR:gl_ozone_glx.cc(28)] GLSurfaceGLX::InitializeOneOff failed.
[5124:5124:1127/153355.129953:5124429238:FATAL:base_renderer.cc(15)] Check failed: vertex_shader_handle. Error compiling shader: 0:1(10): error: GLSL ES 1.00 is not supported. Supported versions are: 1.10, and 1.20
vertex_src
#version 100
precision mediump float; uniform mat4 u_ModelViewProjMatrix; uniform vec2 u_CornerOffset; attribute vec4 a_Position; attribute vec2 a_CornerPosition; attribute vec2 a_OffsetScale; varying vec2 v_TexCoordinate; varying vec2 v_CornerPosition; void main() { v_CornerPosition = a_CornerPosition; vec4 position = vec4( a_Position[0] + u_CornerOffset[0] * a_OffsetScale[0], a_Position[1] + u_CornerOffset[1] * a_OffsetScale[1], a_Position[2], a_Position[3]); v_TexCoordinate = vec2(0.5 + position[0], 0.5 - position[1]); gl_Position = u_ModelViewProjMatrix * position; }
#0 0x00000056d28c base::debug::StackTrace::StackTrace()
#1 0x000000577cfc logging::LogMessage::~LogMessage()
#2 0x000000a84ea1 vr::BaseRenderer::BaseRenderer()
#3 0x000000a858ff vr::TexturedQuadRenderer::TexturedQuadRenderer()
#4 0x000000a86520 vr::ExternalTexturedQuadRenderer::ExternalTexturedQuadRenderer()
#5 0x000000a8419f vr::UiElementRenderer::Init()
#6 0x000000a8416a vr::UiElementRenderer::UiElementRenderer()
#7 0x000000a8300e vr::Ui::OnGlInitialized()
#8 0x000000410604 vr::UiPixelTest::MakeUi()
#9 0x000000411e2b vr::UiPixelTest_DrawVrBrowsingMode_Test::TestBody()
#10 0x000000477826 testing::Test::Run()
#11 0x000000478000 testing::TestInfo::Run()
#12 0x0000004784e7 testing::TestCase::Run()
#13 0x00000047e9d7 testing::internal::UnitTestImpl::RunAllTests()
#14 0x00000047e657 testing::UnitTest::Run()
#15 0x000000556cb2 base::TestSuite::Run()
#16 0x000000558ebe base::(anonymous namespace)::LaunchUnitTestsInternal()
#17 0x000000558d7b base::LaunchUnitTests()
#18 0x00000041018c main
#19 0x7f28be0dbf45 __libc_start_main
#20 0x00000041002a _start
[5/5] UiPixelTest.DrawVrBrowsingMode (CRASHED)
1 test crashed:
    UiPixelTest.DrawVrBrowsingMode (../../chrome/browser/vr/ui_pixeltest.cc:29)


Logs:
https://logs.chromium.org/v/?s=chromium/bb/chromium.fyi/VR_Linux/1156/+/recipes/steps/vr_pixeltests/0/stdout

Assigning to owner of https://chromium-review.googlesource.com/679296
 

Comment 1 by aluo@chromium.org, Dec 1 2017

Labels: chromium-flakiness
Cc: vollick@chromium.org
Owner: tiborg@chromium.org
Tibor, sorry I didn't ping when this came in - forwarding to you now.  Looks like (at least some of) the builders are more picky about shader version?

I don't think this was a result of the unittest/pixeltest split, as AFAIK, the pixel tests still run on the same bots they used to.
Cc: bsheedy@chromium.org
bsheedy@, do we still have to run the pixel test on the FYI bot once we have proper pixel tests?
If we want to run them on Linux, we pretty much have to since the FYI bot's specifically set up to compile Linux binaries with VR enabled. If the tests run on other platforms, we can do that instead, though.

Strangely, compiling the pixel tests on my workstation and manually triggering a swarming job with it (on the same sorts of Ubuntu 14.04 bots that the tests are failing on right now) seems to work fine.
Assigning to bsheedy@ since he is working on infra and pixel tests. I'm a bit confused why gl_ozone_glx.cc is used here. I thought we don't use ozone for the pixel tests. Or is the name just misleading?
Cc: -bsheedy@chromium.org tiborg@chromium.org
Owner: bsheedy@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a9bfca2f17b004b0212a5329553f6e5bb0e9fa

commit 65a9bfca2f17b004b0212a5329553f6e5bb0e9fa
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Dec 08 00:30:10 2017

Remove vr_pixeltests from VR Linux bot

Temporarily removes vr_pixeltests from running on the VR Linux FYI bot.
The test fails on swarming bots due to some compatability issue with
ozone, but will be re-enabled once that has been fixed.

Bug:  791087 
Change-Id: I199721b7aa2fc30ecb0d2424570f940795bfefb3
Reviewed-on: https://chromium-review.googlesource.com/815694
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522641}
[modify] https://crrev.com/65a9bfca2f17b004b0212a5329553f6e5bb0e9fa/testing/buildbot/chromium.fyi.json

Status: Fixed (was: Assigned)
The bot is green now that the test has been removed. Issue 793352 has been filed to fix the underlying cause of the crash.

Sign in to add a comment