New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791079 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

paygenbuildcanary failing on boards with ARC++

Project Member Reported by ahass...@chromium.org, Dec 1 2017

Issue description


Paygenbuildcananry and tests are failing. The error message below is attached from one of the outputs. This happens on boards with ARC++.

05:47:07: INFO: Checking payload integrity
05:47:08: INFO: RunCommand: /tmp/cbuildbot-tmpEbOUL8/tmpVtP5ae/paygen_payload.CYmEn5/au-generator/cros_generate_update_payload --outside_chroot --extract --image /tmp/cbuildbot-tmpEbOUL8/tmpVtP5ae/paygen_payload.CYmEn5/tgt_image.bin --src_image /tmp/cbuildbot-tmpEbOUL8/tmpVtP5ae/paygen_payload.CYmEn5/src_image.bin in /tmp/cbuildbot-tmpEbOUL8/tmpVtP5ae/paygen_payload.CYmEn5/au-generator
05:47:12: INFO: Applying delta payload and verifying result
05:47:41: INFO: RunCommand: /b/c/cbuild/repository/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' -h x-goog-if-generation-match:1512134589318633 rm gs://chromeos-releases/canary-channel/veyron-minnie/10176.0.0/payloads/LOCK_flag
05:47:42: ERROR: Failed: Build definition (board=u'veyron-minnie', version='10176.0.0', channel='canary-channel')
05:47:42: INFO: RunCommand: /b/c/cbuild/repository/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil rm -R gs://chromeos-releases/canary-channel/veyron-minnie/10176.0.0/payloads/signing
05:47:42: ERROR: <type 'exceptions.OSError'>: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/b/c/cbuild/repository/chromite/lib/parallel.py", line 603, in TaskRunner
    task(*x, **task_kwargs)
  File "/b/c/cbuild/repository/chromite/lib/parallel.py", line 801, in <lambda>
    fn = lambda idx, task_args: out_queue.put((idx, task(*task_args)))
  File "/b/c/cbuild/repository/chromite/lib/paygen/paygen_build_lib.py", line 249, in _GenerateSinglePayload
    dry_run=dry_run)
  File "/b/c/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 828, in CreateAndUploadPayload
    dry_run=dry_run).Run()
  File "/b/c/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 708, in Run
    self._drm(self._VerifyPayload)
  File "/b/c/cbuild/repository/chromite/lib/paygen/dryrun_lib.py", line 46, in __call__
    return self.Run(func, *args, **kwargs)
  File "/b/c/cbuild/repository/chromite/lib/paygen/dryrun_lib.py", line 83, in Run
    return self._Call(func, *args, **kwargs)
  File "/b/c/cbuild/repository/chromite/lib/paygen/dryrun_lib.py", line 87, in _Call
    return func(*args, **kwargs)
  File "/b/c/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 682, in _VerifyPayload
    self._ApplyPayload(payload, is_delta)
  File "/b/c/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 642, in _ApplyPayload
    payload.Apply(bspatch_path=bspatch_path, **part_files)
  File "/b/c/cbuild/repository/src/aosp/system/update_engine/scripts/update_payload/payload.py", line 321, in Apply
    old_rootfs_part=old_rootfs_part)
  File "/b/c/cbuild/repository/src/aosp/system/update_engine/scripts/update_payload/applier.py", line 627, in Run
    self.payload.manifest.old_rootfs_info)
  File "/b/c/cbuild/repository/src/aosp/system/update_engine/scripts/update_payload/applier.py", line 575, in _ApplyToPartition
    new_part_file, new_part_info.size)
  File "/b/c/cbuild/repository/src/aosp/system/update_engine/scripts/update_payload/applier.py", line 525, in _ApplyOperations
    new_part_file)
  File "/b/c/cbuild/repository/src/aosp/system/update_engine/scripts/update_payload/applier.py", line 426, in _ApplyDiffOperation
    subprocess.check_call(puffpatch_cmd)
  File "/usr/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
<type 'exceptions.OSError'>: [Errno 2] No such file or directory
 
I think I know what is the problem, We forgot to pass the path to puffin binary and now it cannot find the binary. Will send a fix for it soon.
uploaded these two CLs for a possible fix:

- crrev.com/c/803656
- crrev.com/c/804201
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/dfb053eba34f9d3ffbc69969d0827f767d6769bd

commit dfb053eba34f9d3ffbc69969d0827f767d6769bd
Author: Amin Hassani <ahassani@google.com>
Date: Sat Dec 02 04:32:31 2017

paygen: Pass the path to puffin binary to payload.Apply

This is needed in order to verfiy a delta payload when running the paygenbuild
tests in canary. This fixes the canary builds.

BUG= chromium:791079 
TEST=tryjob
CQ-DEPEND=CL:803656

Change-Id: I3776bcf63f94e0a85f669f73e3a6186c1859de67
Reviewed-on: https://chromium-review.googlesource.com/804201
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/dfb053eba34f9d3ffbc69969d0827f767d6769bd/lib/paygen/paygen_payload_lib.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/6be716878b4027e6c2617bb7c3ce2c877331d1d2

commit 6be716878b4027e6c2617bb7c3ce2c877331d1d2
Author: Amin Hassani <ahassani@google.com>
Date: Sat Dec 02 04:32:30 2017

update_payload: Add puffin binary path to paycheck.py

We forgot to add the path to the puffin binary to paycheck.py and payload.py and
this caused the canary builds fail for minor version 4. This patch fixes it.

BUG= chromium:791079 
TEST=tryjob

Change-Id: I194ab9d9d0b93fc9d456b994f73424d7dedbf181
Reviewed-on: https://chromium-review.googlesource.com/803656
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/6be716878b4027e6c2617bb7c3ce2c877331d1d2/scripts/update_payload/payload.py
[modify] https://crrev.com/6be716878b4027e6c2617bb7c3ce2c877331d1d2/scripts/paycheck.py

Labels: Merge-Request-64
I would like to merge the two cls on this bug back to m64. Thanks.
I think they should be safe to merge back, and I think 64 is new enough to avoid excessive merge issues.
Cc: kbleicher@chromium.org josa...@chromium.org
Labels: M-64 ReleaseBlock-Dev
Labels: -Merge-Request-64 Merge-Approved-64
Status: Assigned (was: Untriaged)
Cc: nxia@chromium.org bhthompson@chromium.org leecy@chromium.org ahass...@chromium.org
 Issue 791842  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 5 2017

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/bb52f9e939ce3bef979a94363bf2c0cd13a28225

commit bb52f9e939ce3bef979a94363bf2c0cd13a28225
Author: Amin Hassani <ahassani@google.com>
Date: Tue Dec 05 03:41:04 2017

update_payload: Add puffin binary path to paycheck.py

We forgot to add the path to the puffin binary to paycheck.py and payload.py and
this caused the canary builds fail for minor version 4. This patch fixes it.

BUG= chromium:791079 
TEST=tryjob

Change-Id: I194ab9d9d0b93fc9d456b994f73424d7dedbf181
Reviewed-on: https://chromium-review.googlesource.com/803656
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
(cherry picked from commit 6be716878b4027e6c2617bb7c3ce2c877331d1d2)

[modify] https://crrev.com/bb52f9e939ce3bef979a94363bf2c0cd13a28225/scripts/update_payload/payload.py
[modify] https://crrev.com/bb52f9e939ce3bef979a94363bf2c0cd13a28225/scripts/paycheck.py

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7ed9cf35ce99291213883b395cf3c4b0482523ec

commit 7ed9cf35ce99291213883b395cf3c4b0482523ec
Author: Amin Hassani <ahassani@google.com>
Date: Tue Dec 05 05:04:29 2017

paygen: Pass the path to puffin binary to payload.Apply

This is needed in order to verfiy a delta payload when running the paygenbuild
tests in canary. This fixes the canary builds.

BUG= chromium:791079 
TEST=tryjob
CQ-DEPEND=CL:807529

Change-Id: I3776bcf63f94e0a85f669f73e3a6186c1859de67
Reviewed-on: https://chromium-review.googlesource.com/804201
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
(cherry picked from commit dfb053eba34f9d3ffbc69969d0827f767d6769bd)
Reviewed-on: https://chromium-review.googlesource.com/807329
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Commit-Queue: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/7ed9cf35ce99291213883b395cf3c4b0482523ec/lib/paygen/paygen_payload_lib.py

Safe to remove as a dev blocker?  Looks like CL/803656 was merged for the next DEV candidate (10176.5.0):

https://crosland.corp.google.com/log/10176.0.0..10176.5.0
Labels: -ReleaseBlock-Dev
Status: Fixed (was: Assigned)
Done :)
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-64

Sign in to add a comment