New issue
Advanced search Search tips

Issue 791073 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Google Docs Offline extension causing error messages when opening files from Chrome OS files app

Reported by lovseb.s...@gmail.com, Dec 1 2017

Issue description

Chrome Version: <63.0.3239.70 (Official Build) beta (64-bit)>
Chrome OS Version: <10032.59.0 (Official Build) beta-channel cyan>
Chrome OS Platform: <Acer Chromebook R 11 CB5-132T-C1HZ>
Network info: <N/A>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Install extension Google Docs Offline (ghbmnnjooekpmoecnnnilnnbdlolhkhi)
(2) Enable offline sync at docs.google.com or drive.google.com
(3) Open any .gdoc, .gsheet, .gslides or .gdraw file from native ChromeOs file browser.

Expected Result:
File opens without any error messages displayed.

Actual Result:
Google drive error message appears saying: "This error has been reported to Google and we'll look into it as soon as possible. Please reload this page to continue."

After click "Ok" button the file reloads without error message.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

As long as the extension is enabled the issue persists, always.

What is the impact to the user, and is there a workaround? If so, what is
it?

Workaround is disabling the extension which leads to a loss of offline access to files.

Please provide any additional information below. Attach a screen shot or
log if possible.

The issue was originally found on my Toshiba Chromebook 2 and a thread was opened on Chromebook Central forums. 

https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/chromebook-central/cLDPI_c-A8U/a_lAt27lAgAJ

I recently bought a new Acer R 11 (partly to get rid of the issue) and the problem persists on the new device.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screenshot 2017-11-20 at 11.09.45.png
116 KB View Download
Components: Platform>Apps>FileManager
Owner: weifangsun@chromium.org
Cc: yamaguchi@chromium.org weifangsun@chromium.org
Labels: -Pri-3 M-64 Pri-2
Owner: fukino@chromium.org
Status: Assigned (was: Unconfirmed)
FR: https://listnr.corp.google.com/report/84766038000
FYI - Docs team is investigating under b/70537743.
Much appreciated! I'm very much looking forwards to a bug fix. 
Cc: -weifangsun@chromium.org fukino@chromium.org
Owner: weifangsun@chromium.org
Cc: mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org weifangsun@chromium.org
 Issue 792567  has been merged into this issue.
I'm seeing this issue in a different scenario. Google Drive error message was seen when a Google doc was shared between 2 users. Here is the scenario I executed:
1. Login as User A. Goto drive.google.com, share a Google doc with User B.
2. Now login as User B and open this shared document from Files app (Files> Google Drive> Shared with me folder).
3. Google Drive error message got displayed. Refer the attached screenshot.
Screenshot 2017-12-22 at 12.09.49 PM.png
198 KB View Download
Labels: -M-64 M-65

Comment 9 by falken@chromium.org, Jan 22 2018

Components: Blink>ServiceWorker
Owner: horo@chromium.org
Status: Fixed (was: Assigned)
https://bugs.chromium.org/p/chromium/issues/detail?id=776408#c10 fixed this issue. It landed in 65.0.3319.0. Copied below:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a50a39ec3867e1816e63a0fe116a91692ca99f

commit 38a50a39ec3867e1816e63a0fe116a91692ca99f
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Jan 11 10:18:28 2018

Create ServiceWorkerRequestHandler for ExternalFileScheme

When a file in Drive is opened from ChromeOS Files app, Chrome opens
"externalfile" scheme URL. And ExternalFileURLRequestJob redirects the request
to the Drive's HTTPS URL.

Currently ServiceWorkerRequestHandler::InitializeForNavigation() doesn't create
a ServiceWorkerProviderHost for the "externalfile" scheme URL.
So ServiceWorkerProviderHost is not created during the navigation.

A new ServiceWorkerProviderHost will be created when ServiceWorkerDispatcherHost
receives OnProviderCreated() IPC from the renderer process.
https://chromium.googlesource.com/chromium/src/+/86ff9bc/content/browser/service_worker/service_worker_dispatcher_host.cc#355

But SetDocumentUrl() of the ServiceWorkerProviderHost which is created here will
not be called because the navigation is already finished.
So all ServiceWorker related API in the page will fail with
"No URL is associated with the caller's document." error.

Bug: 776408
Change-Id: Ic4a0cd2ec5fb16ff995fb96927ca3fea61c3359a
Reviewed-on: https://chromium-review.googlesource.com/861558
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528590}
[modify] https://crrev.com/38a50a39ec3867e1816e63a0fe116a91692ca99f/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/38a50a39ec3867e1816e63a0fe116a91692ca99f/content/browser/service_worker/service_worker_request_handler_unittest.cc

Great guys, many thanks! I’m really looking forwards to the bugfix rolling out to my device so that I can start working offline effortlessly again.
Status: Verified (was: Fixed)
Verified on Chrome OS 10323.12.0, 65.0.3325.39 dev build.

Sign in to add a comment