Omnibox animation overlapped onto Tabswitcher icon when navigating between webpages. |
||||||||||
Issue descriptionApp Version: 63.0.3239.73 beta iOS Version: 11.2, 11.1.2 Device: iPhone7, iPhoneX URL: any Steps to reproduce: 1. Launch Google Chrome 2. Goto any webpage (ex: techmeme.com) 3. Perform a google search in omnibox in the same tab 4. Tab Back arrow 5. And then Forward arrow Observed results: Observe that while omnibox url is updating, the end of the url is floating from the tabswitcher icon Expected results: Animation should not be overlapping from tabswitcher icon Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M62 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M63 Yes Link to video/image: https://drive.google.com/file/d/1Hg4jnQxi3e--5QLaUNU19ipcFCnrkWep/view
,
Dec 12 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b896bfb535c54d75ecd59993cc1987f85d8383e commit 1b896bfb535c54d75ecd59993cc1987f85d8383e Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Dec 13 10:47:55 2017 Make location bar clip to bounds. Makes the location bar clip to bounds. Bug: 791068 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59eff7def75de42d7e75b8bac87d0ada726a61ba Reviewed-on: https://chromium-review.googlesource.com/822255 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523736} [modify] https://crrev.com/1b896bfb535c54d75ecd59993cc1987f85d8383e/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/1b896bfb535c54d75ecd59993cc1987f85d8383e/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Dec 18 2017
,
Dec 18 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 19 2017
stkhapugin@ should this be merged in M64?
,
Dec 19 2017
Animation looks good on M65.0.3299.0 canary Verified on iPhoneX, iOS11.2.5 beta
,
Dec 27 2017
,
Dec 27 2017
Yes, this should be merged. The change is trivial and low risk.
,
Dec 27 2017
This bug requires manual review: Less than 23 days to go before AppStore submit on M64 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2 2018
I don't think this issue should be a blocker for M64 but approving the merge since the fix is quite trivial.
,
Jan 5 2018
Please merge this as soon as possible.
,
Jan 8 2018
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de830fcc7fc8bb47dc45bd13298e52bac922a86a commit de830fcc7fc8bb47dc45bd13298e52bac922a86a Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Mon Jan 08 10:54:47 2018 Make location bar clip to bounds. Makes the location bar clip to bounds. TBR=stkhapugin@chromium.org (cherry picked from commit 1b896bfb535c54d75ecd59993cc1987f85d8383e) Bug: 791068 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59eff7def75de42d7e75b8bac87d0ada726a61ba Reviewed-on: https://chromium-review.googlesource.com/822255 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523736} Reviewed-on: https://chromium-review.googlesource.com/853862 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#441} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/de830fcc7fc8bb47dc45bd13298e52bac922a86a/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/de830fcc7fc8bb47dc45bd13298e52bac922a86a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Jan 10 2018
Verified in: App Version: 64.0.3282.85 beta Devices: iPhone 6S Plus, iPhone 6 iOS Versions: 10.3.3, 11.1 Omnibox animation issue is fixed. It is not overlapping tab switcher icon. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by justincohen@chromium.org
, Dec 6 2017Labels: M-64 ReleaseBlock-Stable
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)