Issue metadata
Sign in to add a comment
|
CreditCardTest.GetLastUsedDateForDisplay failing |
||||||||||||||||||||||
Issue descriptioncomponents_unittests failing on multiple builders Builders failed on: - KitKat Phone Tester (dbg): https://build.chromium.org/p/chromium.android/builders/KitKat%20Phone%20Tester%20%28dbg%29 - KitKat Phone Tester (rel): https://build.chromium.org/p/chromium.android/builders/KitKat%20Phone%20Tester%20%28rel%29 - KitKat Tablet Tester: Total failure, details here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=CreditCardTest
,
Dec 1 2017
+components/autofill/OWNERS.
,
Dec 1 2017
Removing from sheriff queue as this should no longer block anything, but keeping open as needs to be fixed and reenabled.
,
Dec 1 2017
,
Dec 1 2017
Jason can you take a look since you are working on last used date?
,
Dec 1 2017
The reason is it is compare against the real now(), because we don't have a way to mock now() at that time, +sebsg@chromium.org any suggestions?
,
Dec 4 2017
,
Dec 4 2017
One way to fake base::Time::Now is to modify the production code to use base::Clock instead of base::Time directly and then use base::SimpleTestClock in the tests.
,
Dec 4 2017
Jason, take a look at AutofillClock that we use in tests.
,
Dec 4 2017
More specifically, take a look at this class : https://cs.chromium.org/chromium/src/components/autofill/core/browser/test_autofill_clock.h?q=test_autofill_clock&sq=package:chromium&dr=CS&l=5 It will help you mock the time as you want in tests.
,
May 1 2018
,
Aug 2
,
Aug 12
Mark as fixed as the whole lastuseddate feature is removed along with these tests.
,
Nov 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 1 2017