New issue
Advanced search Search tips

Issue 791047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Get rid of has_major_certificate_errors

Project Member Reported by est...@chromium.org, Dec 1 2017

Issue description

ResourceResponseInfo::has_major_certificate_errors is redundant as of https://chromium-review.googlesource.com/c/chromium/src/+/797536. We now pass |cert_status| unconditionally on ResourceResponseInfo, and has_major_certificate_errors can be computed from it. We can get rid of that field.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c

commit 9694a4c5ea2289ac47eff8bf9c6d85ac409d674c
Author: Emily Stark <estark@google.com>
Date: Sat Dec 09 01:43:35 2017

Get rid of has_major_certificate_errors

This field is used to downgrade the browser security UI when a page loads a
subresource over a connection with certificate errors. It was needed because we
used to only populate cert_status conditionally when devtools is open. Now we
populate cert_status unconditionally, so this field is redundant.

Bug:  791047 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib49bd1642801c401cd16a152009f87dccb905c3e
Reviewed-on: https://chromium-review.googlesource.com/817854
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522957}
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/common/resource_messages.h
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/network/url_loader.cc
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/public/common/resource_response.cc
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/public/common/resource_response_info.cc
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/public/common/resource_response_info.h
[modify] https://crrev.com/9694a4c5ea2289ac47eff8bf9c6d85ac409d674c/content/renderer/loader/web_url_loader_impl.cc

Labels: M-65
Status: Fixed (was: Started)

Sign in to add a comment