Typing shield broken on omnibox after device rotation. |
|||||
Issue descriptionApp Version: 64.0.3282.0 canary iOS Version: 11.2 Device: iPhoneX only URL: any Steps to reproduce: 1. Launch Google Chrome 2. Navigate to techmeme.com 3. Tap omnibox to focus 4. Rotate the device to landscape mode 5. Tap on the webpage Observed results: Webpage responds to the touch and links are navigated. Expected results: Webpage shouldb't respond to the first touch. On first tap, Keyboard should simply be dismissed and omnibox editing should be dismissed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M62 YES Bug reproducible on the current beta channel build (App Version, iOS Version): M63 YES Link to video/image: https://drive.google.com/file/d/1UXJGgRJuv7aiePpzzdWI-LKLYYC6onJQ/view
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41b1f381f546b9ae5623d24284dabcd8703e0727 commit 41b1f381f546b9ae5623d24284dabcd8703e0727 Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 04 15:22:08 2017 [ios] More safe area fixes for iPhone X layout. Bug: 789151 , 789633, 791040 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic0db7db4255f01d5875e0072707886746e58274a Reviewed-on: https://chromium-review.googlesource.com/803079 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521341} [modify] https://crrev.com/41b1f381f546b9ae5623d24284dabcd8703e0727/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/41b1f381f546b9ae5623d24284dabcd8703e0727/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Dec 4 2017
,
Dec 5 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d1cd1b0d3974447adff16c7e5c1cb0f341dfc0f commit 9d1cd1b0d3974447adff16c7e5c1cb0f341dfc0f Author: Justin Cohen <justincohen@google.com> Date: Tue Dec 05 14:58:24 2017 [ios] More safe area fixes for iPhone X layout. TBR=justincohen@google.com (cherry picked from commit 41b1f381f546b9ae5623d24284dabcd8703e0727) Bug: 789151 , 789633, 791040 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic0db7db4255f01d5875e0072707886746e58274a Reviewed-on: https://chromium-review.googlesource.com/803079 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521341} Reviewed-on: https://chromium-review.googlesource.com/809064 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#28} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/9d1cd1b0d3974447adff16c7e5c1cb0f341dfc0f/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/9d1cd1b0d3974447adff16c7e5c1cb0f341dfc0f/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Dec 7 2017
Verified in 64.0.3282.14 beta, iPhone X iOS 11.2 Looks good. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by justincohen@chromium.org
, Dec 1 2017