New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791032 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 791059



Sign in to add a comment

Modify eventupload to *only* accept proto messages

Project Member Reported by katthomas@chromium.org, Dec 1 2017

Issue description

If you send a proto message, instead of a pointer to a proto, eventupload should return an error that tells you what you did wrong. 
 
Is it okay to just make Put's src parameter be []*proto.Message now? 
I'm not sure, I have to double-check the usage... That would be ideal though.
Blockedon: 791059
Summary: Modify eventupload to *only* accept proto messages (was: eventupload should fail with a helpful message)
Nope, not yet. completed_builds and completed_steps do not use Messages yet. I'm going to make a bug for that.

https://bugs.chromium.org/p/chromium/issues/detail?id=791059


EstimatedDays: 1
Status: Started (was: Assigned)
We're removing the build instrumentation from kitchen. Nodir, the current data that kitchen is reporting is incorrect, right? Should we just remove the instrumentation for builds from kitchen?

For steps, we're planning on keeping the instrumentation in kitchen, but replacing it with a new schema?   

Comment 6 by no...@chromium.org, Jan 22 2018

Cc: no...@chromium.org
yes, we should just remove it

for steps, we are going to pipe them to buildbucket and buildbucket will report them. in any case, kitchen will not send data to bq

I recommend ...*proto.Message instead of []*proto.Message.
...*proto.Message is easier to use if you have a constant number of events.
Status: Fixed (was: Started)

Sign in to add a comment