New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Leaking IAccessible from WM_GETOBJECT

Project Member Reported by dougt@chromium.org, Dec 1 2017

Issue description

From Nektar:

----
On
https://msdn.microsoft.com/en-us/library/windows/desktop/dd318451(v=vs.85).aspx
it says that when a window handles the WM_GETOBJECT message it should
pass an IAccessible pointer to LresultFromObject and return the HRESULT
to the client after which it should release the pointer. We don't do
this meaning that our accessibility objects will never get destroyed.

See legacy_render_widget_host_win.cc
----


Looking at how this call is handled in Gecko, they do release after this call:

https://dxr.mozilla.org/mozilla-central/source/accessible/windows/msaa/nsWinUtils.cpp#183


 

Comment 1 by dougt@chromium.org, Dec 1 2017

Summary: Leaking IAccessible from WM_GETOBJECT (was: We )

Comment 2 by dougt@chromium.org, May 17 2018

Status: Fixed (was: Available)
We use Microsoft::WRL::ComPtr to hold the IAccessible ptr which releases when it goes out of scope:

Example:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/legacy_render_widget_host_win.cc?type=cs&sq=package:chromium&g=0&l=247


Sign in to add a comment