New issue
Advanced search Search tips

Issue 791025 link

Starred by 1 user
Status: Fixed
Owner:
pauljensen@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

NetworkChangeNotifier crashes on devices that fail with "Too many NetworkRequests filed"

Project Member Reported by pauljensen@chromium.org, Dec 1 2017 
Internal bug b/62654284

Some specific devices seem to incorrectly throw IllegalArgumentException when apps call ConnectivityManager.registerNetworkCallback

We should catch this when the NetworkChangeNotifier is initialized and return false for NetworkChangeNotifierAndroid::AreNetworkHandlesCurrentlySupported().

Comment 1 by pauljensen@chromium.org, Dec 1 2017

Status: Started (was: Assigned)
Prototyped fix: https://chromium-review.googlesource.com/c/chromium/src/+/803115
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425b403722d811bc99cffadfd3e3d00adb1d4c74

commit 425b403722d811bc99cffadfd3e3d00adb1d4c74
Author: Paul Jensen <pauljensen@chromium.org>
Date: Mon Dec 04 14:53:59 2017

Make NetworkChangeNotifierAndroid handle registerNetworkCallback failure

On certain devices ConnectivityManager.registerNetworkCallback fails
unexpectedly.  Handle this by disabling network-specific callbacks
and network binding.

Bug:  791025 
Change-Id: I41054c8e373d9ae6cca99d845280ca56575ccf54
Reviewed-on: https://chromium-review.googlesource.com/803115
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521336}
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierNoNativeTest.java
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/network_change_notifier_android.cc
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/network_change_notifier_delegate_android.cc
[modify] https://crrev.com/425b403722d811bc99cffadfd3e3d00adb1d4c74/net/android/network_change_notifier_delegate_android.h
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 7 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac

commit 53b7ebc3d072236e61cf0e0e25940fc0d7a391ac
Author: Paul Jensen <pauljensen@chromium.org>
Date: Thu Dec 07 14:11:30 2017

Make NetworkChangeNotifierAndroid handle registerNetworkCallback failure

On certain devices ConnectivityManager.registerNetworkCallback fails
unexpectedly.  Handle this by disabling network-specific callbacks
and network binding.

TBR=pauljensen@chromium.org

(cherry picked from commit 425b403722d811bc99cffadfd3e3d00adb1d4c74)

Bug:  791025 
Change-Id: I41054c8e373d9ae6cca99d845280ca56575ccf54
Reviewed-on: https://chromium-review.googlesource.com/803115
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521336}
Reviewed-on: https://chromium-review.googlesource.com/814175
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#73}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierNoNativeTest.java
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/network_change_notifier_android.cc
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/network_change_notifier_delegate_android.cc
[modify] https://crrev.com/53b7ebc3d072236e61cf0e0e25940fc0d7a391ac/net/android/network_change_notifier_delegate_android.h

Comment 6 by pauljensen@chromium.org, Dec 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment