New issue
Advanced search Search tips

Issue 791022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

WebRtcEventLogManagerTest.LocalLogMayNotBeStartedTwice misbehaves on Win7 trybots

Project Member Reported by eladalon@google.com, Dec 1 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
This fails sometimes on Win7 trybots.

What is the expected behavior?

What went wrong?
That remains to be seen. :-)

Did this work before? N/A 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 7
Flash Version:
 
Labels: Needs-Triage-M62 TE-NeedsTriageHelp
As per summary,issue seems to be related to Test Failures on Bots which will not be able to triage from our end. Hence,adding'TE-NeedsTriageHelp' label for further triaging.

Thanks.
Components: Blink>WebRTC>Tools
Owner: eladalon@chromium.org
Status: Assigned (was: Unconfirmed)
eladalon@: Assigning to you since this seems to be caused by r520941, authored by you.
Thanks, Guido.
rkalavakuntla, please leave this for me.
Labels: -TE-NeedsTriageHelp -Via-Wizard-Other -Needs-Triage-M62
Labels: M-64
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61506017f35374ac1b2ac94dba19b348f53c2c12

commit 61506017f35374ac1b2ac94dba19b348f53c2c12
Author: Elad Alon <eladalon@chromium.org>
Date: Tue Dec 12 08:45:54 2017

Avoid WebRTC event log messages when not needed

WebRtcEventLogManager needs to be aware of all peer connections, so
that it may start/stop WebRTC event logging on a per peer connection
basis. This is needed because we only want WebRTC sending RTC event
logs back to Chrome, when Chrome intends to log them. For that reason,
we move the logic from WebRTCEventLogHost into WebRtcEventLogManager,
which will know when these event logs are needed (either for local
or for remote logging).

Bug: 775415,  787809 ,  787938 ,  791022 
Change-Id: I4fda5269765d510c69ce6061a0a5bce3125ffc5f
Reviewed-on: https://chromium-review.googlesource.com/811647
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523377}
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/BUILD.gn
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/media/peer_connection_tracker_host.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/media/peer_connection_tracker_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host.cc
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host.h
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals_unittest.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/browser/render_process_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/test/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/226ae5da35e1cf8da99e551686e020fab613c15f

commit 226ae5da35e1cf8da99e551686e020fab613c15f
Author: maxmorin <maxmorin@chromium.org>
Date: Tue Jan 02 12:50:43 2018

Disable all WebRtcInternalsTests.

These tests are now very flaky.

Bug: 775415,  787809 ,  787938 ,  791022 ,  796047 
Tbr: phoglund@chromium.org
Notry: True
Change-Id: I3ace2542e573d533aab6cfbc1558e4a7ebccce30
Reviewed-on: https://chromium-review.googlesource.com/846882
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526466}
[modify] https://crrev.com/226ae5da35e1cf8da99e551686e020fab613c15f/content/browser/webrtc/webrtc_internals_unittest.cc

Status: Fixed (was: Assigned)
No longer an issue.

Sign in to add a comment