New issue
Advanced search Search tips

Issue 790979 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 779989



Sign in to add a comment

UA CSS resources are miscounted by the leak detector

Project Member Reported by beccahughes@chromium.org, Dec 1 2017 
crrev.com/c/757138 was reverted due to a blink leak.

It turns out the UA CSS resources were in some cases being double counted by InstanceCounter. This meant that when the UA CSS resources were subtracted from the live resources the unsigned int was negative and became a positive. This resulted in incorrect leak test failures.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1085cbf44c1fbdfda0b946923aeaac92ef029029

commit 1085cbf44c1fbdfda0b946923aeaac92ef029029
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Dec 06 15:51:55 2017

Media Controls: Count the UA resources on the resource itself.

Move the UA resource counter into ImageResource itself. This means it
will always line up with the corresponding Resource counter and there is
no chance of a miscount.

BUG= 790979 

Change-Id: Icbb514b151cf9b2800807e3a201db51bdd506076
Reviewed-on: https://chromium-review.googlesource.com/803347
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522098}
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/loader/resource/ImageResource.h
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/style/StyleImage.cpp
[modify] https://crrev.com/1085cbf44c1fbdfda0b946923aeaac92ef029029/third_party/WebKit/Source/core/style/StyleImage.h

Comment 2 by beccahughes@chromium.org, Dec 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment