New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790957 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP is flaky on Windows

Project Member Reported by treib@chromium.org, Dec 1 2017

Issue description

LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP is flaky on Windows:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP

I'll add some failure logs as comments (they don't always look the same).
 

Comment 1 by treib@chromium.org, Dec 1 2017

[ RUN      ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP
[5092:7832:1130/162852.512:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir8016_5924\results8016_18095\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioagfqje\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir8016_5924\d8016_16626" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=TestFeatureForBrowserTest1,UseGoogleLocalNtp --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5092:2896:1130/162853.194:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../base/test/histogram_tester.cc(177): error:       Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "Blink.UseCounter.Features" does not have the right number of samples (1) in the expected bucket (52). It has (0).
../../base/test/histogram_tester.cc(177): error:       Expected: expected_count
      Which is: 2
To be equal to: actual_count
      Which is: 0
Histogram "Blink.UseCounter.Features" does not have the right number of samples (2) in the expected bucket (52). It has (0).
[5092:7832:1130/162854.093:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP, where TypeParam =  and GetParam() =  (1834 ms)

Comment 2 by treib@chromium.org, Dec 1 2017

[ RUN      ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP
[5276:3812:1130/195733.262:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4776_13787\results4776_1868\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iovufvzd\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4776_13787\d4776_23529" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=TestFeatureForBrowserTest1,UseGoogleLocalNtp --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5276:4828:1130/195734.081:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../base/test/histogram_tester.cc(54): error: Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Blink.UseCounter.Features" does not exist.
[5276:3812:1130/195734.564:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP, where TypeParam =  and GetParam() =  (2526 ms)

Comment 3 by treib@chromium.org, Dec 1 2017

[ RUN      ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP
[4728:6028:1130/184755.527:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7788_31625\results7788_14441\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io_ulxvr\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7788_31625\d7788_23781" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=TestFeatureForBrowserTest1,UseGoogleLocalNtp --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[4728:7980:1130/184756.272:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../base/test/histogram_tester.cc(177): error:       Expected: expected_count
      Which is: 2
To be equal to: actual_count
      Which is: 1
Histogram "Blink.UseCounter.Features" does not have the right number of samples (2) in the expected bucket (52). It has (1).
[4728:6028:1130/184756.819:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] LocalNTPTest.ShouldNotTrackBlinkUseCounterForNTP, where TypeParam =  and GetParam() =  (1435 ms)
Labels: zine-triaged
Triage ping: Flakiness dashboard has no red tests (anymore?). Is this fixed?

Comment 6 by treib@chromium.org, Dec 14 2017

No red boxes, but a bunch of gray ones, which means it's flaky. Still valid.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486ead8398efa5552e0137cd8ee3fc9a5280c6fc

commit 486ead8398efa5552e0137cd8ee3fc9a5280c6fc
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Jun 14 14:44:56 2018

Remove legacy features histogram from blink

Tests for counting features are removed from the blink side because
there are browser side testing them, please see:
chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Tests for frame fetch context is removed, but there's still test
coverage in
chromium/src/chrome/browser/client_hints/client_hints_browsertest.cc

Tests for blink side use counter dropping ntp activities is no longer
needed as blink side use counter is being removed.

TBR: nhiroki@chromium.org
Bug:  849695 ,  790957 
Change-Id: I32b0d01b768c7043fb01f2329cc089049126ed2b
Reviewed-on: https://chromium-review.googlesource.com/1087045
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567259}
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/content/browser/service_worker/service_worker_browsertest.cc
[add] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/runtime/runtime-evaluate-silent-expected.txt
[add] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/runtime/runtime-evaluate-silent.js
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/frame/use_counter_test.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc

Status: WontFix (was: Assigned)
The test is now removed. 

Sign in to add a comment