New issue
Advanced search Search tips

Issue 790922 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Suppress false leaks caused v8 way to shut in tests

Reported by apisa...@yandex-team.ru, Dec 1 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
1. Enable webkit_unit_tests.WebEmbeddedWorkerImplTest.DontPauseAfterDownload with lsan
2. Run test it

What is the expected behavior?
Everything is ok

What went wrong?
False leak, caused by not calling weak ref callback.

Did this work before? N/A 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

I think it is better to suppress this particular leak, instead of disable whole test.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ab4d619f5b412ceb73559d738f6b8f2c31200d

commit a0ab4d619f5b412ceb73559d738f6b8f2c31200d
Author: Alexander Pisarev <apisarev@yandex-team.ru>
Date: Fri Dec 01 09:46:37 2017

Suppressing false leaks caused by v8 fast shut in tests.

v8 weak ref callbacks don't call at the end of a test. And there is
cleaning logic for ScriptState and DOMWrapperWorld. This cause false
leaks detect by lsan. I think it 's better to suppress them, instead of
disabling whole tests.

Bug:  790922 , 586897
Change-Id: Ie86ae86994c8442fa0b779de62ab0904171a14de
Reviewed-on: https://chromium-review.googlesource.com/800614
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520900}
[modify] https://crrev.com/a0ab4d619f5b412ceb73559d738f6b8f2c31200d/build/sanitizers/lsan_suppressions.cc
[modify] https://crrev.com/a0ab4d619f5b412ceb73559d738f6b8f2c31200d/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp

Comment 2 by dtapu...@chromium.org, Dec 4 2017

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment