New issue
Advanced search Search tips

Issue 790892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

debugger-eval-on-call-frame-inside-iframe.js flaky on all platforms

Project Member Reported by timloh@chromium.org, Dec 1 2017

Issue description

The test debugger-eval-on-call-frame-inside-iframe.js (both the normal test and virtual/mojo-loading) has recently been flakily failing on all platforms. In the past, it has only been failing on Windows. The failure looks like this:

@@ -18,12 +18,13 @@
 setTimeout (async)
 scheduleTestFunction @ VM:3
 (anonymous) @ VM:1
+error: Attempt to select missing item
 
 === Evaluating on top frame ===
-dir() = undefined
-dirxml() = "overridden dirxml() in top frame"
-table = 
-clear = "local in top frame"
+dir() = "overridden dir() in iframe"
+dirxml() = undefined
+table = "local in iframe"
+clear = 
 x: = VM:1 Uncaught SyntaxError: Unexpected end of input
     at Object.pauseInsideIframe (<anonymous>:6:5)
     at testFunction (debugger-eval-on-cal…inside-iframe.js:35)


The first instance is from rev 519189, so it would be one of the devtools changes not long before it.

Suspect candidates: https://crrev.com/5eae5f19 https://crrev.com/820c5f13 https://crrev.com/1cd17e61
Git log: https://chromium.googlesource.com/chromium/src/+log/81c9f48e22bda64beed7bda744edd81fd107400e
Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showAllRuns=true&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger-pause%2Fdebugger-eval-on-call-frame-inside-iframe.js
Sample failed run: https://storage.googleapis.com/chromium-layout-test-archives/Linux_Tests/65132/layout-test-results/results.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582ff658023c12ece92f4fb9733e21563a4abc13

commit 582ff658023c12ece92f4fb9733e21563a4abc13
Author: Timothy Loh <timloh@chromium.org>
Date: Fri Dec 01 05:34:18 2017

Mark debugger-eval-on-call-frame-inside-iframe.js flaky on all platforms

The test has recently been flaking on all platforms, so expand the
expectation from just Win7.

Bug:  790892 
Change-Id: I83adcb388c4048a5e4a88fc17bfda37964cebc12
TBR: kozyatinskiy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/802846
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520860}
[modify] https://crrev.com/582ff658023c12ece92f4fb9733e21563a4abc13/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by kozy@chromium.org, Dec 5 2017

Owner: kozy@chromium.org

Comment 4 by kozy@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment