Find in Page UI disappears when triggered during exit animation, but still partially works |
||||||||
Issue descriptionChrome Version: 64.0.3282.0 (tip of tree for the past day or so) OS: Linux What steps will reproduce the problem? (1) Ctrl-F to open Find in Page UI (2) Type some text to find (3) Close the find bar: Escape key, Ctrl-R to reload the page, etc. (4) While the find bar is closing, Ctrl-F to open the Find in Page UI again What is the expected result? The find bar appears. What happens instead? The find bar does not appear, but some functionality is still active. Specifically: 1. The text that would be in the find bar is empty, so nothing is highlighted 2. Typing some text types it into the (non-existent) find bar, causing the page to be highlighted as you type just as if the find bar was visible 3. The Enter key does NOT move to the next result 4. Pressing Escape "closes" the non-existent find bar. This happens when the find bar shortcut is triggered while the exit animation of the find bar is still playing from when it was closed.
,
Dec 1 2017
also occurs on 63.0.3239.59
,
Dec 21 2017
I'm not sure who owns the Find bar, could someone please triage this?
,
Jan 20 2018
Still repros in 65.
,
Jan 22 2018
Repros for me too. Allen, I'm guessing this is related to your find bar changes.
,
Jan 22 2018
I can reproduce it in 63, which is before any of my changes. I suspect it's been there for a while.
,
Jan 22 2018
Okay. Lowering priority since it's not a regression.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4aaba6c281b2034a66eab6fda2f344023560af3 commit c4aaba6c281b2034a66eab6fda2f344023560af3 Author: Allen Bauer <kylixrd@chromium.org> Date: Tue Jan 30 21:12:16 2018 Find-in-page UI would disappear if re-invoked while the close animation was progressing but not yet finished. Make sure any close animation is finished and the drop-down bar state is consistent before showing. Bug: 790889 Change-Id: I5a8edbfe398d048ef226ea849c4c9d285b1ec564 Reviewed-on: https://chromium-review.googlesource.com/893213 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#533023} [modify] https://crrev.com/c4aaba6c281b2034a66eab6fda2f344023560af3/chrome/browser/ui/views/dropdown_bar_host.cc
,
Jan 30 2018
,
Jan 31 2018
Verified the fix on Ubuntu 14.04 and Windows 10 using Chrome version #66.0.3335.0 as per the comment #0. Attaching screen cast for reference. Observed that after performing Ctrl+F, searched some content, Esc, Ctrl+R(Reload) then -> Ctrl+F, Find bar appeared. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by michae...@chromium.org
, Dec 1 2017