Update DOMString with USVString in IDL |
||||
Issue descriptionSome of latest web standards have been updated to use USVString instead of DOMString. For example, below specifications have already used USVString instead of DOMString for their attributes. - https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers - https://html.spec.whatwg.org/multipage/history.html#location - https://xhr.spec.whatwg.org/#the-send()-method This issue is to track to support to change DOMString with USVString as well as to discuss issues on it.
,
Dec 1 2017
For the record, below 2 CLs were to update it. - https://chromium-review.googlesource.com/c/chromium/src/+/776516 - https://chromium-review.googlesource.com/c/chromium/src/+/784752
,
Dec 6 2017
gyuyoung.kim@ are you already working on this...? If so, could you put your name in "Owner" field and change the status to "Started"? Thanks!
,
Dec 6 2017
kochi@, sure, in fact, I've already uploaded some CLs - https://chromium-review.googlesource.com/c/chromium/src/+/781320 - https://chromium-review.googlesource.com/c/chromium/src/+/786932 >If so, could you put your name in "Owner" field and change the status >to "Started"? ok!
,
Dec 6 2017
,
Dec 6 2017
In the whatwg specification, it was done by this PR, - https://github.com/whatwg/html/pull/1282 There are some reasons to use USVString instead of DOMString, - https://url.spec.whatwg.org/#url-apis-elsewhere - https://url.spec.whatwg.org/#url-code-points
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26635467c354ce2a49e0a39765c67cd11790804b commit 26635467c354ce2a49e0a39765c67cd11790804b Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Wed Dec 06 14:25:47 2017 Update DOMString url types with USVString in the NavigatorContentUtils.idl Latest spec has used USVString instead of DOMString for url argument. - spec: https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers This CL replaces DOMString type with USVString type according to the spec. Bug: 790860 Change-Id: I179144780bd345bc71e9b9beeaea3470a8e3d302 Reviewed-on: https://chromium-review.googlesource.com/781320 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#522081} [modify] https://crrev.com/26635467c354ce2a49e0a39765c67cd11790804b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.idl
,
Dec 7 2017
,
Dec 7 2017
Copying one of my comments from https://chromium-review.googlesource.com/c/chromium/src/+/781320#message-48fb0ae341317f09aee74e0c14a21b4a0ec6cb0e explaining the background of the use of USVString for URLs in IDLs. It's done in the context of https://github.com/whatwg/html/pull/1282 See also https://url.spec.whatwg.org/#url-apis-elsewhere and https://url.spec.whatwg.org/#url-code-points for the reason.
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54505ed37b6481db30874b2ee35bfb899872dbe9 commit 54505ed37b6481db30874b2ee35bfb899872dbe9 Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Date: Tue Dec 12 15:41:33 2017 Updated DOMString type with USVString for URL-related IDL attributes/operations Updated DOMString type with USVString for URL-related IDL attributes/operations to match the html specification. https://html.spec.whatwg.org/ Bug: 790860 Change-Id: I23a10706e309305d5da337c0b43c79b9faec8a22 Reviewed-on: https://chromium-review.googlesource.com/808404 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#523435} [add] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/frame/Location.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLAnchorElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLAreaElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLBaseElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLFrameElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLLinkElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/core/html/HTMLSourceElement.idl [modify] https://crrev.com/54505ed37b6481db30874b2ee35bfb899872dbe9/third_party/WebKit/Source/modules/eventsource/EventSource.idl
,
Dec 15 2017
I am workng on a patch to update DOMString type with USVString for window.open url. Thanks!
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79fa11cbba4353e9d0b7307faf7e6162daf632c2 commit 79fa11cbba4353e9d0b7307faf7e6162daf632c2 Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Date: Tue Dec 19 14:09:43 2017 Updated DOMString type with USVString for window.open url Updated DOMString type with USVString for window.open url to match the html specification. https://html.spec.whatwg.org/multipage/window-object.html#the-window-object Bug: 790860 Change-Id: I371655167c3a99c121512cad91be950c75fc0a93 Reviewed-on: https://chromium-review.googlesource.com/829153 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Cr-Commit-Position: refs/heads/master@{#525014} [modify] https://crrev.com/79fa11cbba4353e9d0b7307faf7e6162daf632c2/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/79fa11cbba4353e9d0b7307faf7e6162daf632c2/third_party/WebKit/Source/core/frame/Window.idl
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0266d84ee6c8e90966412fe7423a03ae9efe5cf6 commit 0266d84ee6c8e90966412fe7423a03ae9efe5cf6 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Dec 21 05:00:14 2017 Updated DOMString type with USVString for URL in StorageEvent Latest spec has used USVString instead of DOMString for url argument. - spec: https://html.spec.whatwg.org/multipage/webstorage.html#the-storageevent-interface This CL replaces DOMString type with USVString type according to the spec. Bug: 790860 Change-Id: Ib781fb1ca32399035bb824b8d78241a97d574655 Reviewed-on: https://chromium-review.googlesource.com/831320 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#525617} [modify] https://crrev.com/0266d84ee6c8e90966412fe7423a03ae9efe5cf6/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/0266d84ee6c8e90966412fe7423a03ae9efe5cf6/third_party/WebKit/Source/modules/storage/StorageEvent.idl [modify] https://crrev.com/0266d84ee6c8e90966412fe7423a03ae9efe5cf6/third_party/WebKit/Source/modules/storage/StorageEventInit.idl
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/213fd10de1ab1b5aced3e95e216a6784b49f446e commit 213fd10de1ab1b5aced3e95e216a6784b49f446e Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Dec 21 07:04:01 2017 Updated DOMString type with USVString for URL in WebSocket.idl Latest spec has used USVString instead of DOMString for url argument. - spec: https://html.spec.whatwg.org/multipage/web-sockets.html#the-websocket-interface This CL replaces DOMString type with USVString type according to the spec. Bug: 790860 Change-Id: Id30e1456f6e3eda045043b37123b82544e6e2f03 Reviewed-on: https://chromium-review.googlesource.com/824143 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#525634} [modify] https://crrev.com/213fd10de1ab1b5aced3e95e216a6784b49f446e/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/213fd10de1ab1b5aced3e95e216a6784b49f446e/third_party/WebKit/Source/modules/websockets/WebSocket.idl
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/deacd1a22024b270eeb9622a702e2a987dc23507 commit deacd1a22024b270eeb9622a702e2a987dc23507 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Tue Jan 09 02:23:41 2018 Replace DOMString type with USVStrin for URL properties in Document.idl Latest spec has used USVString instead of DOMString for url argument. - spec: https://dom.spec.whatwg.org/#interface-document Bug: 790860 Change-Id: Ia8744c4dc97047afe11a5d328673412bdfcefeb7 Reviewed-on: https://chromium-review.googlesource.com/853535 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#527870} [modify] https://crrev.com/deacd1a22024b270eeb9622a702e2a987dc23507/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/deacd1a22024b270eeb9622a702e2a987dc23507/third_party/WebKit/Source/core/dom/Document.idl
,
Jan 15 2018
I am working on replacing DOMString type with USVString for location.href. Thanks!
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bcf633afa439ca0aee8b955156593c352b340f3 commit 1bcf633afa439ca0aee8b955156593c352b340f3 Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Date: Wed Jan 17 02:55:11 2018 Modified location |href| atribute type from DOMString to USVString location |href| is implemented as URLString which is typedefed as (DOMString or TrustedURL). As per spec, |href| should be USVString. Since URLString is used only for |href| attribute, So 'DOMString' is modified to 'USVString' in typedef. https://html.spec.whatwg.org/multipage/history.html#location Bug: 790860 Change-Id: Ia76a5bb760216978a85316b29cb7415c6585feef Reviewed-on: https://chromium-review.googlesource.com/866619 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Cr-Commit-Position: refs/heads/master@{#529556} [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.idl [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/Source/core/frame/Location.cpp [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/Source/core/frame/Location.h [modify] https://crrev.com/1bcf633afa439ca0aee8b955156593c352b340f3/third_party/WebKit/Source/core/frame/Location.idl
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f164b48cc02fbcb3c27cf53910818423fb11e3ae commit f164b48cc02fbcb3c27cf53910818423fb11e3ae Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Jan 18 12:18:48 2018 [USVString] Change the type of url with USVString in navigator.sendBeacon Latest spec has used USVString instead of DOMString for url argument. - spec: https://w3c.github.io/beacon/#dom-navigator-sendbeacon This CL replaces DOMString type with USVString type according to the spec. Bug: 790860 Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7 Reviewed-on: https://chromium-review.googlesource.com/869970 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#530123} [modify] https://crrev.com/f164b48cc02fbcb3c27cf53910818423fb11e3ae/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/f164b48cc02fbcb3c27cf53910818423fb11e3ae/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.idl
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f73ccec7a667bde2737e20ed0ae3da62483b2669 commit f73ccec7a667bde2737e20ed0ae3da62483b2669 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Jan 18 16:09:47 2018 Revert "[USVString] Change the type of url with USVString in navigator.sendBeacon" This reverts commit f164b48cc02fbcb3c27cf53910818423fb11e3ae. Reason for revert: Appears to cause usvstring-reflection.html test failures on WebKit Linux Trusty Leak, e.g.: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/14513 04:33:47.078 30339 worker/3 external/wpt/html/dom/usvstring-reflection.html failed: 04:33:47.078 30339 worker/3 leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLivePausableObjects":[2,3],"numberOfLiveResources":[0,3]}) Original change's description: > [USVString] Change the type of url with USVString in navigator.sendBeacon > > Latest spec has used USVString instead of DOMString for url argument. > - spec: https://w3c.github.io/beacon/#dom-navigator-sendbeacon > > This CL replaces DOMString type with USVString type according to the spec. > > Bug: 790860 > Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7 > Reviewed-on: https://chromium-review.googlesource.com/869970 > Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Cr-Commit-Position: refs/heads/master@{#530123} TBR=tyoshino@chromium.org,gyuyoung.kim@lge.com Change-Id: I36a251d058756f509daa330c952546b7a1064130 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790860 Reviewed-on: https://chromium-review.googlesource.com/874050 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530154} [modify] https://crrev.com/f73ccec7a667bde2737e20ed0ae3da62483b2669/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/f73ccec7a667bde2737e20ed0ae3da62483b2669/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.idl
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf88154ac0134a84bba13fc4bec7b0a0939c673 commit 1bf88154ac0134a84bba13fc4bec7b0a0939c673 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Fri Jan 19 04:47:54 2018 Reland "[USVString] Change the type of url with USVString in navigator.sendBeacon" This is a reland of I66825c20395ea6fd6b26e32fc8f6508fd85aeef7. Original CL caused a memory leak for the layout test. This CL fixes it speculatively. Bug: 790860 Change-Id: I0daac689085625b4954bac34991e28addea6f8e1 Reviewed-on: https://chromium-review.googlesource.com/874977 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#530424} [modify] https://crrev.com/1bf88154ac0134a84bba13fc4bec7b0a0939c673/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/1bf88154ac0134a84bba13fc4bec7b0a0939c673/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.idl
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31851349da5c7d2cd7906305544b80a139701c52 commit 31851349da5c7d2cd7906305544b80a139701c52 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Fri Feb 09 07:49:25 2018 Reland "Update remained DOMString types with ByteString or USVString in the XMLHttpRequest"" This reverts commit 4239eae58f46aeef299268e9c936b6d0f3eb4ef0. The original patch broke wpt/XMLHttpRequest/send-authentication-competing-names-passwords.html. Following CL fixed it. - "bindings: Handle V8StringResourceMode in string type NativeValueTraits specializations" So the original CL is re-landed. Bug: 790860 Change-Id: Id7f6d7d3313cc5653af4415c3dab62be66f0963c Reviewed-on: https://chromium-review.googlesource.com/908174 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#535666} [delete] https://crrev.com/38ffc080ebc21ef8e06da302811e2f3ac32bd671/third_party/WebKit/LayoutTests/external/wpt/xhr/setrequestheader-bogus-name-expected.txt [delete] https://crrev.com/38ffc080ebc21ef8e06da302811e2f3ac32bd671/third_party/WebKit/LayoutTests/external/wpt/xhr/setrequestheader-bogus-value-expected.txt [modify] https://crrev.com/31851349da5c7d2cd7906305544b80a139701c52/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl
,
Feb 9 2018
https://chromium-review.googlesource.com/c/chromium/src/+/904525 is the patch referred in the last comment. See also bug 808995 .
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f217ee8959a11ba9b50e7bc1778234937f4b0b commit d4f217ee8959a11ba9b50e7bc1778234937f4b0b Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Feb 15 14:53:40 2018 [USVString] Apply USVString into RTCDataChannel.send Latest spec changed DOMString type of send with USVString. - https://w3c.github.io/webrtc-pc/#dom-rtcdatachannel This CL applies USVString type into the RTCDataCchannel.send according to the spec. Bug: 790860 Change-Id: I3d2e3fef8e6a8cc8ca94a8ae18c2ccb7dcc48016 Reviewed-on: https://chromium-review.googlesource.com/917741 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537015} [modify] https://crrev.com/d4f217ee8959a11ba9b50e7bc1778234937f4b0b/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/d4f217ee8959a11ba9b50e7bc1778234937f4b0b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.idl
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b761842aab4a59c63b6e125e56c88eb1de55932 commit 7b761842aab4a59c63b6e125e56c88eb1de55932 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Mon Feb 26 09:59:17 2018 [USVString] Apply USVString into Document.origin The latest spec changed DOMString type of Document.origin with USVString. - https://dom.spec.whatwg.org/#document This CL applies USVString type into the Document.origin in order to meet the change. Bug: 790860 Change-Id: Ibd1fafa28a6e999f7d3085aa7bb4cca0f92d8b2b Reviewed-on: https://chromium-review.googlesource.com/928005 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#539096} [modify] https://crrev.com/7b761842aab4a59c63b6e125e56c88eb1de55932/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html [modify] https://crrev.com/7b761842aab4a59c63b6e125e56c88eb1de55932/third_party/WebKit/Source/core/dom/Document.idl
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a95cd07e7312afe074ed40f4be8c3b0ddbe0c6a9 commit a95cd07e7312afe074ed40f4be8c3b0ddbe0c6a9 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Mon Feb 26 13:01:26 2018 [USVString] Add a rough test case for navigator.registerProtocolHandler Although r525634 updated the URL type of registerProtocolHandler from DOMString to USVString, it didn't add a test case because it was a bit complex. Though it's still hard to add a test case for it, this CL adds a rough test case for now. Bug: 790860 Change-Id: Ia688494293274ab2c0aa62f9e33a588ca80d2a82 Reviewed-on: https://chromium-review.googlesource.com/933668 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#539114} [modify] https://crrev.com/a95cd07e7312afe074ed40f4be8c3b0ddbe0c6a9/third_party/WebKit/LayoutTests/external/wpt/html/dom/usvstring-reflection.html
,
Apr 11 2018
It seems like that DOMString types have been replaced with USVString. So I'd like to close this issue. But if there are more needs to replace it with USVString, let me re-open this issue.
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2404f196f123fb3741932de77327efce728567a2 commit 2404f196f123fb3741932de77327efce728567a2 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Tue Dec 04 05:13:03 2018 [USVString] Add a rough test case for navigator.unregisterProtocolHandler Although r525634 updated the URL type of registerProtocolHandler from DOMString to USVString, it didn't add a test case because it was a bit complex. And also, issue 933668 added the rough test for navigator.registerProtocolHandler. But, it didn't add a test for the navigator.unregisterProtocolHandler. So this CL adds a rough test case for navigator.unregisterProtocolHandler. Bug: 790860 Change-Id: Ib54c058e4c61db59b73486d28fbd3db5bfdd36c7 Reviewed-on: https://chromium-review.googlesource.com/c/1359976 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#613425} [modify] https://crrev.com/2404f196f123fb3741932de77327efce728567a2/third_party/blink/web_tests/external/wpt/html/dom/usvstring-reflection.html |
||||
►
Sign in to add a comment |
||||
Comment 1 by gyuyoung...@chromium.org
, Dec 1 2017