New issue
Advanced search Search tips

Issue 790856 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gerrit_util.py in depot_tools should use LUCI auth (or do everything through 'git')

Project Member Reported by vadimsh@chromium.org, Dec 1 2017 
This one: https://cs.chromium.org/chromium/tools/depot_tools/gerrit_util.py?q=gerrit_util.py&sq=package:chromium&dr&l=241

The thing it does currently (reading tokens from .gitcookies or use GCE metadata server) will not work on LUCI.

Instead it should use https://cs.chromium.org/chromium/tools/depot_tools/auth.py?sq=package:chromium&dr&l=332 (that already supports LUCI auth) with fallback to .gitcookies for local runs (if developers ever run it locally).

Alternatively, if it can work exclusively through 'git', it should just do that, since 'git' already works with proper authentication in all environments.

Comment 1 by tandrii@chromium.org, Dec 1 2017

Labels: LUCI-M0-Backlog
I don't think it can work with pure git* since it needs Gerrit change metadata.
So, we'll need to make use auth package linked above.

Also, until this is fixed, presubmit builders won't be reliable on LUCI.


* technically, this metadata is stored in git objects, so it's possible, but from maintenance and time-to-market PoV unwise :)

Comment 2 by estaab@chromium.org, Dec 5 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)

Comment 3 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 4 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog
►

Sign in to add a comment