Design doc here: https://docs.google.com/document/d/173clv-oSMgDyIKyMn4LD0GWOEUEOwYnyVfj7k4dA0HA/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7896c18d7d1ae0246660efa69d19ca7224938c2d commit 7896c18d7d1ae0246660efa69d19ca7224938c2d Author: spqchan <spqchan@chromium.org> Date: Wed Jan 10 00:28:57 2018 Implement Dynamic Interstitial Introduced Dynamic Interstitial class to ssl_error_assistant.proto. In SSLErrorAssistant, implemented the logic that load the data and then match it with the information from the SSL error. If a match is found, display the dynamic interstitial via SSLErrorHandler. Modified SSLBlockingPage and SSLErrorUi so that the support URL can be customized by the dynamic interstitial Testing: - Unit tests - SSLErrorAssistantTest.DynamicInterstitialListMatch - SSLErrorAssistantTest.DynamicInterstitialListMatchUnknownCertError - SSLErrorAssistantTest.DynamicInterstitialListCertErrorMismatch - SSLErrorAssistantTest.DynamicInterstitialListHashesMismatch - Browser tests - SSLUIDynamicInterstitialTest.Match - SSLUIDynamicInterstitialTest.MatchUnknownCertError - SSLUIDynamicInterstitialTest.MismatchHash - SSLUIDynamicInterstitialTest.MismatchCertError Bug: 790850 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd9b6f111608f96e230410cb832a0edbc18e6f7c Reviewed-on: https://chromium-review.googlesource.com/838741 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#528186} [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_blocking_page.h [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.h [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.proto [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant_unittest.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler.h [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler_unittest.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_tab_helper_unittest.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/ssl_error_ui.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/ssl_error_ui.h [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/superfish_error_ui.cc [modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9dd06e096636b4fd44d955a633fa1e079080990 commit b9dd06e096636b4fd44d955a633fa1e079080990 Author: spqchan <spqchan@chromium.org> Date: Mon Feb 05 23:06:04 2018 Add MitM support in Dynamic Interstitials Add support for MitM software in Dynamic Interstitials. Testing: Unit tests in SSLErrorAssistantTest Browser tests in SSLUIDynamicInterstitialTest Bug: 790850 Change-Id: If6c174d8e207bf51d34e8dcd75ffd2c284f36e05 Reviewed-on: https://chromium-review.googlesource.com/865834 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#534523} [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_error_assistant.cc [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_error_assistant.h [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_error_assistant.proto [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_error_assistant_unittest.cc [modify] https://crrev.com/b9dd06e096636b4fd44d955a633fa1e079080990/chrome/browser/ssl/ssl_error_handler.cc
Assigning for estark@ for future triage
Comment 1 by rsleevi@chromium.org
, Dec 1 2017