New issue
Advanced search Search tips

Issue 790850 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Implement Urgent Interstitials

Project Member Reported by spqc...@chromium.org, Dec 1 2017

Issue description

Components: -Internals>Network>SSL UI>Browser>Interstitials
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7896c18d7d1ae0246660efa69d19ca7224938c2d

commit 7896c18d7d1ae0246660efa69d19ca7224938c2d
Author: spqchan <spqchan@chromium.org>
Date: Wed Jan 10 00:28:57 2018

Implement Dynamic Interstitial

Introduced Dynamic Interstitial class to ssl_error_assistant.proto.
In SSLErrorAssistant, implemented the logic that load the data and
then match it with the information from the SSL error. If a match
is found, display the dynamic interstitial via SSLErrorHandler.

Modified SSLBlockingPage and SSLErrorUi so that the support
URL can be customized by the dynamic interstitial

Testing:
- Unit tests
   - SSLErrorAssistantTest.DynamicInterstitialListMatch
   - SSLErrorAssistantTest.DynamicInterstitialListMatchUnknownCertError
   - SSLErrorAssistantTest.DynamicInterstitialListCertErrorMismatch
   - SSLErrorAssistantTest.DynamicInterstitialListHashesMismatch
- Browser tests
   - SSLUIDynamicInterstitialTest.Match
   - SSLUIDynamicInterstitialTest.MatchUnknownCertError
   - SSLUIDynamicInterstitialTest.MismatchHash
   - SSLUIDynamicInterstitialTest.MismatchCertError

Bug: 790850
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibd9b6f111608f96e230410cb832a0edbc18e6f7c
Reviewed-on: https://chromium-review.googlesource.com/838741
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528186}
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_blocking_page.h
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.h
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant.proto
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_assistant_unittest.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler.h
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ssl/ssl_error_tab_helper_unittest.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/ssl_error_ui.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/ssl_error_ui.h
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/components/security_interstitials/core/superfish_error_ui.cc
[modify] https://crrev.com/7896c18d7d1ae0246660efa69d19ca7224938c2d/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

Owner: est...@chromium.org
Assigning for estark@ for future triage

Sign in to add a comment