USB camera capture is broken on ToT on minnie |
|||||||||||
Issue descriptionChrome Version: Google Chrome 64.0.3274.0 OS: Chrome OS veyron_minnie-release/R64-10164.0.0 What steps will reproduce the problem? (1) Boot the device (2) Open the built-in Chrome camera app (3) Check if the camera preview works What is the expected result? The camera preview should output frames constantly. What happens instead? The camera preview stuck on the first frame. Please use labels and text to provide additional information. The video capture stack on minnie with USB camera is broken. Bisect shows that the regression is caused by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/525672
,
Dec 1 2017
Moja. This is high priority. Please submit a fix today.
,
Dec 1 2017
Is M64 branched yet? Will we need to cherry-pick it to M64?
,
Dec 1 2017
According to the schedule it will be branched in several hours (11/30 PST time I believe). We should make sure M64 branch also have the fix once we merge a fix to ToT.
,
Dec 1 2017
This also affects kevin.
,
Dec 1 2017
I think all devices without a hw JPEG decoder is broken now. This line seems suspicious to me: https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_jpeg_decode_accelerator.cc?l=79 IMO we should still check GpuInfo to tell if hw JDA is support or not, instead of always returning true.
,
Dec 1 2017
Okay, so the GpuInfo check is moved to https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc?l=265 which should set the VideoCaptureGpuJpegDecode's initialization state to FAILED on devices that do not support hw JDA. Now I'm not sure how the camera capture stack is broken on rockchip devices...
,
Dec 1 2017
The camera is ok on ELM.
,
Dec 1 2017
Rockchip devices do not support JPEG HW decode.
,
Dec 1 2017
Right. Chances are the USB camera stack is broken on all devices that do not have JPEG HW decoder.
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97537191cfbbca6a2f1d5f4c19c86d34adbe9419 commit 97537191cfbbca6a2f1d5f4c19c86d34adbe9419 Author: Moja Hsu <mojahsu@chromium.org> Date: Fri Dec 01 22:20:32 2017 JDA: Fix deadlock for non-JDA case The code will enter deadlock if the device has no JPEG decode accelerator. This CL fixes it. BUG= chromium:790838 TEST=test camera preview on minnie Change-Id: I695f80351a451614c7c830e3e31b40196fe9b457 Reviewed-on: https://chromium-review.googlesource.com/802935 Reviewed-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521085} [modify] https://crrev.com/97537191cfbbca6a2f1d5f4c19c86d34adbe9419/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
,
Dec 1 2017
The remaining task is to make sure the fix is in M64 once it's branched.
,
Dec 3 2017
,
Dec 3 2017
,
Dec 4 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09787e4f26e9fc9193b732fa53030c4208a52195 commit 09787e4f26e9fc9193b732fa53030c4208a52195 Author: Moja Hsu <mojahsu@chromium.org> Date: Mon Dec 04 16:41:24 2017 JDA: Fix deadlock for non-JDA case The code will enter deadlock if the device has no JPEG decode accelerator. This CL fixes it. BUG= chromium:790838 TEST=test camera preview on minnie Change-Id: I695f80351a451614c7c830e3e31b40196fe9b457 Reviewed-on: https://chromium-review.googlesource.com/802935 Reviewed-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521085}(cherry picked from commit 97537191cfbbca6a2f1d5f4c19c86d34adbe9419) Reviewed-on: https://chromium-review.googlesource.com/804672 Cr-Commit-Position: refs/branch-heads/3282@{#13} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/09787e4f26e9fc9193b732fa53030c4208a52195/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
,
Dec 4 2017
,
Dec 4 2017
Still reproducible on Minni with build chrome OS 10176.3.0, 64.0.3280.5. using built in Chrome camera app..preview view freeze.
,
Dec 4 2017
,
Dec 4 2017
Also repros on Kevin
,
Dec 5 2017
We'll need to wait until the Chrome PFQ to uprev M64 to 64.0.3282.*, which is the Chrome M64 branch.
,
Dec 6 2017
The fix is merged in M64 64.0.3282.9. Please verify with Chrome OS version 10176.5.0 or later.
,
Dec 6 2017
Not reproducible: tested on Minnie and Kevin with build M64 64.0.3282.11, 10176.5.0 (dev)
,
Dec 6 2017
,
Dec 6 2017
Issue 792145 has been merged into this issue. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jcliang@chromium.org
, Dec 1 2017