New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 790836 link

Starred by 1 user
Status: Fixed
Owner:
█ mtomasz@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
mfo...@chromium.org
fukino@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

fsp::ExtensionProvider should be created per each providing extension.

Project Member Reported by mtomasz@chromium.org, Dec 1 2017 
Currently we create one for handling of extensions, which makes the code slightly complicated.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b27c88dd9039c6c9a122cf860117b25b03f761a

commit 8b27c88dd9039c6c9a122cf860117b25b03f761a
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Tue Dec 05 03:52:48 2017

Create ExtensionProvider per each extension.

To match semantics of ExtensionProvider.

Test: All current FSP tests pass.
Bug:  790836 
Change-Id: I6948086c234319031a4ae95664d9216c2fb5f55c
Reviewed-on: https://chromium-review.googlesource.com/802836
Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521608}
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/extension_provider.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/extension_provider.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/fake_extension_provider.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/fake_extension_provider.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/provider_interface.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/service.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/8b27c88dd9039c6c9a122cf860117b25b03f761a/chrome/browser/chromeos/smb_client/smb_service_unittest.cc

Comment 2 by mtomasz@chromium.org, Dec 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment