Get RenderWidgetHostImpl::OnShowDisambiguationPopup off SharedBitmaps |
|||||
Issue descriptionRenderWidgetHostImpl::OnShowDisambiguationPopup uses a SharedBitmapId but that makes the browser depend on being able to look up shared bitmaps. Im putting a TODO to move it to some other shared memory thing. SharedBitmapId is for quads anyway and this is just used to pass a bitmap over and put it in a view/painting.
,
Dec 13 2017
,
Jan 3 2018
,
Jan 3 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d8d5c7cf2769579dc20e237e99c1585175b2c9 commit e7d8d5c7cf2769579dc20e237e99c1585175b2c9 Author: kylechar <kylechar@chromium.org> Date: Fri Jan 05 20:21:53 2018 Don't use SharedBitmap for disambiguation popups. Switch Android disambiguation popups to use SharedMemory instead of SharedBitmap. The disambiguation popup just needs to get pixels from the renderer to browser and doesn't require any of the synchronization provided by SharedBitmaps. This removes a dependency on SharedBitmapManager that we didn't want. Bug: 790807 Change-Id: I4a6652a1a25d64e692fd346e6bce04caa2962657 Reviewed-on: https://chromium-review.googlesource.com/848651 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#527368} [modify] https://crrev.com/e7d8d5c7cf2769579dc20e237e99c1585175b2c9/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/e7d8d5c7cf2769579dc20e237e99c1585175b2c9/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/e7d8d5c7cf2769579dc20e237e99c1585175b2c9/content/common/view_messages.h [modify] https://crrev.com/e7d8d5c7cf2769579dc20e237e99c1585175b2c9/content/renderer/render_view_impl.cc [modify] https://crrev.com/e7d8d5c7cf2769579dc20e237e99c1585175b2c9/content/renderer/render_view_impl.h
,
Jan 8 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by danakj@chromium.org
, Dec 1 2017