Refactor enterprise policy and command line handling |
||||||
Issue descriptionIn https://bugs.chromium.org/p/chromium/issues/detail?id=760761#c12, we discuss 1 item of remaining refactoring work. 1 TODO remains in chrome/browser/prefs/chrome_command_line_pref_store.cc: // TODO( https://crbug.com/760761 ): This is not the ideal way to // implement this. Refactor enterprise policy and command line handling // so that this line isn't necessary, if possible. {switches::kIsolateOrigins, prefs::kIsolateOrigins}, We want to close out that bug, so I'm opening this new bug to track the refactoring.
,
Jan 8 2018
,
Jan 8
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
palmer@, this looks like it was a todo on a change of yours. Assigning to you to prioritize
,
Jan 14
I'm not the right person to do a refactor of enterprise settings; it's not my area. I added those settings as part of the Spectre emergency but am not otherwise knowledgeable.
,
Jan 15
This is fairly complex problem. I think the first step though is still more on the feature side rather than the policy side as discussed back then. In order to fix the policy we need to make the feature capable of [semi-]dynamic config change. I guess we can start this discussion with the question - what is the current default state? Can we switch it on the fly or is this not yet possible? If not can we make it possible? I know the answer used to be no in the past but this was mainly due to time constrains and higher prio issues. Now that the dust has settled can we revisit this?
,
Jan 16
Actually, there was some progress on that front, but I think we'll want to be more specific about what's needed for this bug. alexmos@ just landed r622715 for issue 905513 yesterday, which makes it possible to add additional isolated origins at runtime, which only affect newly opened tabs. This means the current state is: 1) If you start with some set of isolated origins (e.g., at login), you could add to that set (e.g., after login). 2) You cannot remove isolated origins from the set at runtime (e.g., if the policy on the login screen somehow required more origins than after login). 3) You cannot change whether SitePerProcess is enabled at runtime. What's needed for this bug? Is it sufficient to just add origins after login? (CC'ing alexmos@, who might be able to share how to wire it up if that's all we need.) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by emaxx@chromium.org
, Dec 15 2017Labels: Enterprise-Triaged