Black screen sometimes in WebVR on desktop |
||||||
Issue descriptionThere is a finch trial for using a passthrough command decoder instead of the default validating command decoder. This uses different ANGLE APIs for some things, like glBlitFramebuffer[ANGLE], which behave subtly different. In particular for WebVR, validating decoder will do some format conversions for compatible formats (RGB->RGBA), and will support GL_LINEAR interpolation. The passthrough doesn't support either of these. This bug represents the work to make WebVR compatible with both decoders.
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c11f385bc0a6df6510d2bc921f78db6f2808c9d8 commit c11f385bc0a6df6510d2bc921f78db6f2808c9d8 Author: Bill Orr <billorr@chromium.org> Date: Mon Dec 04 21:24:49 2017 Desktop WebVR displays black when using the passthrough command decoder The passthrough command decoder has slightly different behavior than the validating command decoder, as they go through different ANGLE functions (glBlitFrameBuffer vs. glBlitFramebufferANGLE). This means that passthrough doesn't support GL_LINEAR interpolation mode, and is more strict about color formats. The immediate fix to unblock WebVR is to use compatible buffer format, and use GL_NEAREST. A subsequent change (crbug/790033) will reconcile the two behaviors to ensure consistancy. BUG= 790785 Change-Id: I0ac98a923168823f9e6618fef9d6e6e0e974c777 Reviewed-on: https://chromium-review.googlesource.com/802244 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521457} [modify] https://crrev.com/c11f385bc0a6df6510d2bc921f78db6f2808c9d8/third_party/WebKit/Source/platform/graphics/GpuMemoryBufferImageCopy.cpp
,
Dec 4 2017
,
Dec 5 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fbc04583a16069fa0127bc56ef3d06136347002 commit 2fbc04583a16069fa0127bc56ef3d06136347002 Author: Bill Orr <billorr@chromium.org> Date: Wed Dec 06 01:34:43 2017 Desktop WebVR displays black when using the passthrough command decoder The passthrough command decoder has slightly different behavior than the validating command decoder, as they go through different ANGLE functions (glBlitFrameBuffer vs. glBlitFramebufferANGLE). This means that passthrough doesn't support GL_LINEAR interpolation mode, and is more strict about color formats. The immediate fix to unblock WebVR is to use compatible buffer format, and use GL_NEAREST. A subsequent change (crbug/790033) will reconcile the two behaviors to ensure consistancy. BUG= 790785 TBR=billorr@chromium.org (cherry picked from commit c11f385bc0a6df6510d2bc921f78db6f2808c9d8) Change-Id: I0ac98a923168823f9e6618fef9d6e6e0e974c777 Reviewed-on: https://chromium-review.googlesource.com/802244 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521457} Reviewed-on: https://chromium-review.googlesource.com/809818 Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#47} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/2fbc04583a16069fa0127bc56ef3d06136347002/third_party/WebKit/Source/platform/graphics/GpuMemoryBufferImageCopy.cpp
,
Dec 6 2017
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by billorr@chromium.org
, Nov 30 2017