New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 790783 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Jan 2018
Cc:
█ gch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Add CanonicalURLResult (or comparable) histogram on Android.

Project Member Reported by tedc...@chromium.org, Nov 30 2017 
iOS added a histogram to what type of URLs Chrome is sharing, and we should add something similar to Android.

https://chromium-review.googlesource.com/c/chromium/src/+/759141
https://chromium-review.googlesource.com/c/chromium/src/+/759141/13/tools/metrics/histograms/enums.xml

We should try to generalize the histogram to make it not iOS specific if possible.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f

commit 780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f
Author: Ted Choc <tedchoc@google.com>
Date: Wed Jan 03 02:41:04 2018

Add CanonicalURLResult histogram to Android.

This moves the existing iOS histogram/enum to a shared component
and logs the same information in Android.

BUG= 790783 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id9a9391834d55581f498493a7bcfacb7e0416a94
Reviewed-on: https://chromium-review.googlesource.com/818469
Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526599}
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/BUILD.gn
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/android/BUILD.gn
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareMenuActionHandlerIntegrationTest.java
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareMenuActionHandlerTest.java
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/components/ui_metrics/BUILD.gn
[rename] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/components/ui_metrics/canonical_url_share_metrics_types.h
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/components/ui_metrics/sadtab_metrics_types.h
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/ios/chrome/browser/ui/activity_services/canonical_url_retriever.mm
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/ios/chrome/browser/ui/activity_services/canonical_url_retriever_unittest.mm
[modify] https://crrev.com/780bbbd1c16444aa6e0b5f9d0cfafe9c9fbc1b0f/tools/metrics/histograms/histograms.xml

Comment 2 by tedc...@chromium.org, Jan 4 2018

Components: UI>Browser>Mobile>Share
Status: Fixed (was: Assigned)
►

Sign in to add a comment