New issue
Advanced search Search tips

Issue 790780 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

grpc build failed with latest llvm-next

Project Member Reported by llozano@chromium.org, Nov 30 2017

Issue description

new warning. needs to be fixed. 

From here: 

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fchromiumos-sdk%2F2722%2F%2B%2Frecipes%2Fsteps%2FInitSDK%2F0%2Fstdout


grpc-1.3.0-r1: x86_64-pc-linux-gnu-clang -pthread  -Ithird_party/googletest/googletest/include  -g -Wall -Wextra -Werror -Wno-long-long -Wno-unused-parameter -DOSATOMIC_USE_INLINED=1 -O2 -fPIC -I. -Iinclude -I/var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/gens -DNDEBUG -DINSTALL_PREFIX=\"/usr\"     -DTSI_OPENSSL_ALPN_SUPPORT=0 -O2 -pipe -std=c99 -Wsign-conversion -Wconversion -Wshadow -Wextra-semi   -MMD -MF /var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/objs/opt/src/core/lib/channel/handshaker_factory.dep -c -o /var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/objs/opt/src/core/lib/channel/handshaker_factory.o src/core/lib/channel/handshaker_factory.c
grpc-1.3.0-r1: src/core/lib/channel/channel_args.c:228:23: error: implicit conversion changes
grpc-1.3.0-r1:       signedness: 'grpc_compression_algorithm' to 'int'
grpc-1.3.0-r1:       [-Werror,-Wsign-conversion]
grpc-1.3.0-r1:   tmp.value.integer = algorithm;
grpc-1.3.0-r1:                     ~ ^~~~~~~~~
grpc-1.3.0-r1: x86_64-pc-linux-gnu-clang -pthread  -Ithird_party/googletest/googletest/include  -g -Wall -Wextra -Werror -Wno-long-long -Wno-unused-parameter -DOSATOMIC_USE_INLINED=1 -O2 -fPIC -I. -Iinclude -I/var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/gens -DNDEBUG -DINSTALL_PREFIX=\"/usr\"     -DTSI_OPENSSL_ALPN_SUPPORT=0 -O2 -pipe -std=c99 -Wsign-conversion -Wconversion -Wshadow -Wextra-semi   -MMD -MF /var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/objs/opt/src/core/lib/channel/handshaker_registry.dep -c -o /var/tmp/portage/dev-libs/grpc-1.3.0-r1/work/grpc-1.3.0/objs/opt/src/core/lib/channel/handshaker_registry.o src/core/lib/channel/handshaker_registry.c
grpc-1.3.0-r1: 1 error generated.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eebe3e338336885041a3f72d5e0cede18e24c6cd

commit eebe3e338336885041a3f72d5e0cede18e24c6cd
Author: Caroline Tice <cmtice@google.com>
Date: Tue Dec 05 19:00:05 2017

[dev-libs/grpc] Add -Wno-sign-conversion, to build with llvm-next.

The llvm-next version has tightened up sign-conversion checking,
and dev-lib/grpc no longer builds with that flag.  Here we disable
that warning for this package, until the upstream bug can be
fixed (https://github.com/grpc/grpc/issues/13597).  Also make sure the
'make' command actually uses CFLAGS (it was ignoring it before).

BUG=chromium:790780
TEST=Successfully tested with tryjob, for chromiumos-sdk with llvm-next.

Change-Id: Ie3e843b9984fc9a13e1ad0434d813c090ef0ec45
Reviewed-on: https://chromium-review.googlesource.com/803742
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[rename] https://crrev.com/eebe3e338336885041a3f72d5e0cede18e24c6cd/dev-libs/grpc/grpc-1.3.0-r2.ebuild

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Re-opening this, to keep an eye on the upstream bug.
Components: Infra

Comment 5 by mmoss@chromium.org, Jan 2 2018

Components: -Infra Infra>Client>ChromeOS
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
Components: -Infra>Client>ChromeOS
Components: Tools>ChromeOS-Toolchain

Sign in to add a comment